Skip to content

Commit 8105ac2

Browse files
committed
ci: remove continue-on-error for Windows now that tests are stable
1 parent 1a9ae7e commit 8105ac2

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

.github/workflows/tests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ on:
99
jobs:
1010
test:
1111
runs-on: ${{ matrix.os }}
12-
# TODO: remove once shivammathur/setup-php fixes Windows PHP setup
13-
# (broken since windows runner images shipped PHP 8.5, actions/runner-images#13603)
14-
continue-on-error: ${{ contains(matrix.os, 'windows') }}
1512

1613
strategy:
1714
fail-fast: false

src/PHPUnit/ProcessBuilder/PathReplacer.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ describe('PathReplacer', () => {
197197

198198
const path = './tests/AssertionsTest.php';
199199

200-
expect(pathReplacer.toLocal(path)).toEqual('C:\\vscode\\tests\\AssertionsTest.php');
200+
expect(pathReplacer.toLocal(path)).toEqual(phpUnitProjectWin('tests/AssertionsTest.php'));
201201
});
202202

203203
it("can't replace path when ${workspaceFolder} is /", () => {

0 commit comments

Comments
 (0)