fix: phpstan

Author: zembrowski

composer.json

@@ -23,7 +23,8 @@
         "laravel/pint": "^1.18",
         "pestphp/pest": "^2.36|^3.5",
         "pestphp/pest-plugin-type-coverage": "^2.8|^3.2",
-        "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan": "^1.10|^2.0",
+        "phpstan/phpstan-deprecation-rules": "^1.0|^2.0",
         "symfony/browser-kit": "^6.4|^7.2",
         "symfony/console": "^6.4|^7.2",
         "symfony/css-selector": "^6.4|^7.2",
@@ -41,16 +42,18 @@
     },
     "scripts": {
         "analyse": "vendor/bin/phpstan analyse",
+        "arch": "vendor/bin/pest --group=arch",
         "coverage": "vendor/bin/pest --coverage --min=90",
         "format": "vendor/bin/pint",
         "quality": [
+            "@arch",
             "@format",
             "@test",
             "@analyse",
             "@types",
             "@coverage"
         ],
-        "test": "vendor/bin/pest",
+        "test": "vendor/bin/pest --exclude-group=arch",
         "types": "vendor/bin/pest --type-coverage --min=100"
     },
     "bin": [

phpstan-baseline.neon

@@ -1,16 +1,19 @@
 parameters:
 	ignoreErrors:
 		-
-			message: "#^Call to an undefined method Pest\\\\PendingCalls\\\\TestCall\\|Pest\\\\Support\\\\HigherOrderTapProxy\\:\\:expect\\(\\)\\.$#"
-			count: 1
+			message: '#^Call to an undefined method Pest\\PendingCalls\\TestCall\|Pest\\Support\\HigherOrderTapProxy\:\:expect\(\)\.$#'
+			identifier: method.notFound
+			count: 2
 			path: tests/ArchTest.php
 
 		-
-			message: "#^Access to an undefined property Pest\\\\Mixins\\\\Expectation\\<array\\<string, array\\<string, string\\>\\>\\|null\\>\\:\\:\\$not\\.$#"
+			message: '#^Access to an undefined property Pest\\Mixins\\Expectation\<array\<string, array\<string, string\>\>\|null\>\:\:\$not\.$#'
+			identifier: property.notFound
 			count: 1
 			path: tests/RetrieveTest.php
 
 		-
-			message: "#^Access to an undefined property Pest\\\\Mixins\\\\Expectation\\<bool\\|string\\|null\\>\\:\\:\\$not\\.$#"
+			message: '#^Access to an undefined property Pest\\Mixins\\Expectation\<string\|false\|null\>\:\:\$not\.$#'
+			identifier: property.notFound
 			count: 1
 			path: tests/RetrieveTest.php

phpstan.neon

@@ -1,5 +1,7 @@
 includes:
 	- phpstan-baseline.neon
+	- phar://phpstan.phar/conf/bleedingEdge.neon
+	- vendor/phpstan/phpstan-deprecation-rules/rules.neon
 
 parameters:
 	level: 9

src/Retrieve.php

@@ -116,7 +116,7 @@ public function save(mixed $path = '.'): array
 
         $prefix = date('Y-m-d');
 
-        $files['json'] = $this->saveJson($path.DIRECTORY_SEPARATOR.$prefix);
+        $files['json'] = $this->saveJson($path.DIRECTORY_SEPARATOR.$prefix); // @phpstan-ignore-line
 
         return $files;
     }

src/RetrieveCommand.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Rechtlogisch\TseId;
 
 use Symfony\Component\Console\Attribute\AsCommand;

tests/ArchTest.php

@@ -1,5 +1,11 @@
 <?php
 
 test('will not use debugging functions')
-    ->expect(['dd', 'dump', 'ray'])
-    ->not->toBeUsed();
+    ->expect(['dd', 'dump', 'ray', 'var_dump', 'echo', 'print_r'])
+    ->not->toBeUsed()
+    ->group('arch');
+
+test('use strict mode')
+    ->expect('Rechtlogisch\TseId')
+    ->toUseStrictTypes()
+    ->group('arch');