Stop using sh -c to run deployments

With debian (eg. slim) based images, sh will take hold of PID 1, thus preventing signals from being propagated to the intended command. This is not an issue with alpine images. But we want these templates to be agnostic of linux distribution.

Author: dbackeus

generators/deployments/other.yaml

@@ -37,9 +37,9 @@ spec:
         - name: command
           image: {{ .Values.image }}
           command:
-            - sh
-            - c
-            - {{ .Values.scaling.%{camelName}.command }}
+            {{- range .Values.deployments.%{camelName}.command | split " " }}
+            - {{ . | quote }}
+            {{- end }}
           # NOTE: We avoid putting a limit on CPU since Kubernetes throttling kills performance and CPU averages
           # tends to be low, so we can allow some pods to burst when needed. Adjust as you see fit.
           resources:

generators/deployments/sidekiq.yaml

@@ -37,9 +37,9 @@ spec:
         - name: sidekiq
           image: {{ .Values.image }}
           command:
-            - sh
-            - -c
-            - {{ .Values.deployments.%{camelName}.command | default "bundle exec sidekiq" }}
+            {{- range .Values.deployments.%{camelName}.command | default "bundle exec sidekiq" | split " " }}
+            - {{ . | quote }}
+            {{- end }}
           # NOTE: We avoid putting a limit on CPU since Kubernetes throttling kills performance and CPU averages
           # tends to be low, so we can allow some pods to burst when needed. Adjust as you see fit.
           resources:

generators/deployments/web.yaml

@@ -43,9 +43,9 @@ spec:
         - name: web
           image: {{ .Values.image }}
           command:
-            - sh
-            - -c
-            - {{ .Values.deployments.%{camelName}.command | default "bin/rails server" }}
+            {{- range .Values.deployments.%{camelName}.command | default "bundle exec rails server" | split " " }}
+            - {{ . | quote }}
+            {{- end }}
           ports:
             - containerPort: {{ $port }}
           securityContext: