Added distinctRecomms parameter to batch request

Author: OndraFiedler

lib/recombee_api_client/api/batch.rb

@@ -14,11 +14,16 @@ class Batch < ApiRequest
     # * *Required arguments*
     #   - +requests+ -> Array of API requests.
     #
-    def initialize(requests)
+    def initialize(requests, optional = {})
       @requests = requests
+      @optional = optional
       @body_parameters = requests_to_batch_hash
       @timeout = requests.map{|r| r.timeout}.reduce(:+)
       @ensure_https = true
+
+      @optional.each do |par, _|
+        fail UnknownOptionalParameter.new(par) unless ["distinctRecomms"].include? par
+      end
     end
 
     # HTTP method
@@ -47,7 +52,9 @@ def path
     def requests_to_batch_hash
       reqs = []
       @requests.each { |r| reqs.push(request_to_batch_hash r) }
-      {'requests' => reqs}
+      result = {'requests' => reqs}
+      result['distinctRecomms'] = @optional['distinctRecomms'] if @optional.key? 'distinctRecomms'
+      result
     end
 
     def request_to_batch_hash(req)

lib/recombee_api_client/api/list_groups.rb

@@ -16,7 +16,7 @@ class ListGroups < ApiRequest
   ##
   #
     def initialize()
-      @timeout = 1000
+      @timeout = 30000
       @ensure_https = false
     end
 

lib/recombee_api_client/api/list_items.rb

@@ -21,7 +21,7 @@ class ListItems < ApiRequest
     def initialize(optional = {})
       @filter = optional['filter']
       @optional = optional
-      @timeout = 1000
+      @timeout = 30000
       @ensure_https = false
       @optional.each do |par, _|
         fail UnknownOptionalParameter.new(par) unless ["filter"].include? par

lib/recombee_api_client/api/list_series.rb

@@ -16,7 +16,7 @@ class ListSeries < ApiRequest
   ##
   #
     def initialize()
-      @timeout = 1000
+      @timeout = 30000
       @ensure_https = false
     end
 

lib/recombee_api_client/api/list_users.rb

@@ -16,7 +16,7 @@ class ListUsers < ApiRequest
   ##
   #
     def initialize()
-      @timeout = 1000
+      @timeout = 30000
       @ensure_https = false
     end
 

lib/recombee_api_client/api/merge_users.rb

@@ -10,7 +10,7 @@ module RecombeeApiClient
   #Merges purchases, ratings, bookmarks, and detail views of two different users under a single user ID. This is especially useful for online e-commerce applications working with anonymous users identified by unique tokens such as the session ID. In such applications, it may often happen that a user owns a persistent account, yet accesses the system anonymously while, e.g., putting items into a shopping cart. At some point in time, such as when the user wishes to confirm the purchase, (s)he logs into the system using his/her username and password. The interactions made under anonymous session ID then become connected with the persistent account, and merging these two together becomes desirable.
   #
   #
-  #Merging happens between two users referred to as the *source* and the *target*. After the merge, all the interactions of the source user are attributed to the target user, and the source user is **deleted** unless special parameter `keepSourceUser` is set `true`.
+  #Merging happens between two users referred to as the *target* and the *source*. After the merge, all the interactions of the source user are attributed to the target user, and the source user is **deleted** unless special parameter `keepSourceUser` is set `true`.
   #
   class MergeUsers < ApiRequest
     attr_reader :target_user_id, :source_user_id, :keep_source_user, :cascade_create

lib/recombee_api_client/version.rb

@@ -1,3 +1,3 @@
 module RecombeeApiClient
-  VERSION = '1.2.3'
+  VERSION = '1.2.4'
 end

spec/api/add_interaction.rb

@@ -23,6 +23,14 @@
   end
 
   it 'fails with nonexisting item id' do
+    req = described_class.new('entity_id','nonex_id')
+    expect { @client.send(req) }.to raise_exception { |exception|
+       expect(exception).to be_a(RecombeeApiClient::ResponseError)
+       expect(exception.status_code).to eq 404
+     }
+  end
+
+  it 'fails with nonexisting user id' do
     req = described_class.new('nonex_id','entity_id')
     expect { @client.send(req) }.to raise_exception { |exception|
        expect(exception).to be_a(RecombeeApiClient::ResponseError)