feat: replace InvalidArgumentException with BizException and SysException in CategoryStatus and CategoryRecord

Author: aspirantzhang

contexts/CategoryManagement/Domain/Models/CategoryStatus.php

@@ -4,7 +4,7 @@
 
 namespace Contexts\CategoryManagement\Domain\Models;
 
-use InvalidArgumentException;
+use App\Exceptions\BizException;
 
 class CategoryStatus
 {
@@ -17,7 +17,8 @@ class CategoryStatus
     public function __construct(private string $value)
     {
         if (! in_array($value, [self::SUBSPENDED, self::ACTIVE, self::DELETED])) {
-            throw new InvalidArgumentException('Invalid category status');
+            throw BizException::make('Invalid status: :status')
+                ->with('status', $value);
         }
     }
 
@@ -45,19 +46,16 @@ public function transitionTo(CategoryStatus $target): self
         };
 
         if (! in_array($target->value, $validTransitions)) {
-            // TODO: Create a custom exception
-            throw new InvalidArgumentException("Cannot transition from {$this->value} to {$target->value}");
+            throw BizException::make('Cannot transition from :from to :to')
+                ->with('from', $this->value)
+                ->with('to', $target->value);
         }
 
         return $target;
     }
 
     public static function fromString(string $status): self
     {
-        if (! in_array($status, [self::SUBSPENDED, self::ACTIVE, self::DELETED])) {
-            throw new InvalidArgumentException('Invalid category status');
-        }
-
         return new self($status);
     }
 

contexts/CategoryManagement/Infrastructure/Records/CategoryRecord.php

@@ -4,6 +4,7 @@
 
 namespace Contexts\CategoryManagement\Infrastructure\Records;
 
+use App\Exceptions\SysException;
 use App\Http\Models\BaseModel;
 use Contexts\CategoryManagement\Domain\Models\Category;
 use Contexts\CategoryManagement\Domain\Models\CategoryId;
@@ -34,7 +35,7 @@ class CategoryRecord extends BaseModel
     public static function mapStatusToDomain(int $status): CategoryStatus
     {
         if (! isset(self::STATUS_MAPPING[$status])) {
-            throw new \InvalidArgumentException('Invalid status value');
+            throw SysException::make('Invalid status value: '.$status);
         }
 
         return new CategoryStatus(self::STATUS_MAPPING[$status]);
@@ -43,7 +44,7 @@ public static function mapStatusToDomain(int $status): CategoryStatus
     public static function mapStatusToRecord(CategoryStatus $status): int
     {
         if (! in_array($status->getValue(), self::STATUS_MAPPING)) {
-            throw new \InvalidArgumentException('Invalid status value');
+            throw SysException::make('Invalid status value: '.$status->getValue());
         }
 
         return array_search($status->getValue(), self::STATUS_MAPPING);

contexts/CategoryManagement/Tests/Unit/Domain/Models/CategoryStatusTest.php

@@ -2,6 +2,7 @@
 
 declare(strict_types=1);
 
+use App\Exceptions\BizException;
 use Contexts\CategoryManagement\Domain\Models\CategoryStatus;
 
 it('can be created', function (string $validValue) {
@@ -11,7 +12,7 @@
 })->with(['subspended', 'active', 'subspended', 'deleted']);
 
 it('throws an exception when the status is invalid', function (string $invalidValue) {
-    $this->expectException(\InvalidArgumentException::class);
+    $this->expectException(BizException::class);
 
     new CategoryStatus($invalidValue);
 })->with(['invalid', 'status']);
@@ -28,7 +29,7 @@
 it('throws an exception when transitioning to active from active', function () {
     $categoryStatus = new CategoryStatus('active');
 
-    $this->expectException(\InvalidArgumentException::class);
+    $this->expectException(BizException::class);
 
     $categoryStatus->transitionTo(CategoryStatus::active());
 });
@@ -40,7 +41,7 @@
 })->with(['subspended', 'active', 'subspended', 'deleted']);
 
 it('throws an exception when creating from invalid string status', function (string $invalidValue) {
-    $this->expectException(\InvalidArgumentException::class);
+    $this->expectException(BizException::class);
 
     CategoryStatus::fromString($invalidValue);
 })->with(['invalid', 'status']);