chore: typo fix

aspirantzhang · aspirantzhang · commit f291b7347162 · 2025-03-26T22:03:25.000+08:00
diff --git a/contexts/Authorization/Application/Coordinators/RoleCoordinator.php b/contexts/Authorization/Application/Coordinators/RoleCoordinator.php
@@ -78,14 +78,14 @@ public function updateRole(int $id, UpdateRoleDTO $data): Role
         return $role;
     }
 
-    public function subspendRole(int $id)
+    public function suspendRole(int $id)
     {
         CompositePolicy::allOf([
             new GlobalPermissionPolicy('role.suspend'),
         ])->check();
 
         $role = $this->repository->getById(RoleId::fromInt($id));
-        $role->subspend();
+        $role->suspend();
 
         $this->repository->update($role);
 
diff --git a/contexts/Authorization/Application/Coordinators/UserIdentityCoordinator.php b/contexts/Authorization/Application/Coordinators/UserIdentityCoordinator.php
@@ -9,6 +9,7 @@
 use Contexts\Authorization\Application\DTOs\User\GetUserListDTO;
 use Contexts\Authorization\Application\DTOs\User\UpdateUserDTO;
 use Contexts\Authorization\Domain\Factories\UserIdentityFactory;
+use Contexts\Authorization\Domain\Policies\GlobalPermissionPolicy;
 use Contexts\Authorization\Domain\Repositories\UserRepository;
 use Contexts\Authorization\Domain\Role\Models\RoleId;
 use Contexts\Authorization\Domain\UserIdentity\Models\Email;
@@ -18,17 +19,15 @@
 use Contexts\Authorization\Domain\UserIdentity\Models\UserIdentity;
 use Contexts\Authorization\Domain\UserIdentity\Models\UserStatus;
 use Contexts\Shared\Application\BaseCoordinator;
-use Illuminate\Contracts\Pagination\LengthAwarePaginator;
 use Contexts\Shared\Policies\CompositePolicy;
-use Contexts\Authorization\Domain\Policies\GlobalPermissionPolicy;
+use Illuminate\Contracts\Pagination\LengthAwarePaginator;
 
 class UserIdentityCoordinator extends BaseCoordinator
 {
     public function __construct(
         private UserRepository $repository,
         private UserIdentityFactory $factory
-    ) {
-    }
+    ) {}
 
     public function create(CreateUserDTO $data): UserIdentity
     {
@@ -86,14 +85,14 @@ public function updateUser(int $id, UpdateUserDTO $data): UserIdentity
         return $user;
     }
 
-    public function subspendUser(int $id)
+    public function suspendUser(int $id)
     {
         CompositePolicy::allOf([
-            new GlobalPermissionPolicy('user.subspend'),
+            new GlobalPermissionPolicy('user.suspend'),
         ])->check();
 
         $user = $this->repository->getById(UserId::fromInt($id));
-        $user->subspend();
+        $user->suspend();
 
         $this->repository->update($user);
 
diff --git a/contexts/Authorization/Domain/Role/Models/Role.php b/contexts/Authorization/Domain/Role/Models/Role.php
@@ -61,7 +61,7 @@ public static function reconstitute(
         return $role;
     }
 
-    public function subspend()
+    public function suspend()
     {
         $this->transitionStatus(RoleStatus::suspended());
     }
diff --git a/contexts/Authorization/Domain/UserIdentity/Models/UserIdentity.php b/contexts/Authorization/Domain/UserIdentity/Models/UserIdentity.php
@@ -136,7 +136,7 @@ public static function createFromFactory(
         return $user;
     }
 
-    public function subspend()
+    public function suspend()
     {
         $this->transitionStatus(UserStatus::suspended());
     }
diff --git a/contexts/Authorization/Infrastructure/Routes.php b/contexts/Authorization/Infrastructure/Routes.php
@@ -21,7 +21,7 @@
         Route::post('', 'createUser')->name('createUser');
         Route::patch('{id}/password', 'changePassword')->name('changePassword');
         Route::put('{id}/roles', 'updateRoles')->name('updateRoles');
-        Route::put('{id}/subspend', 'subspendUser')->name('subspendUser');
+        Route::put('{id}/suspend', 'suspendUser')->name('suspendUser');
         Route::put('{id}', 'updateUser')->name('updateUser');
         Route::delete('{id}', 'deleteUser')->name('deleteUser');
     });
@@ -30,7 +30,7 @@
         Route::get('', 'getRoleList')->name('getRoleList');
         Route::post('', 'createRole')->name('createRole');
         Route::patch('{id}/password', 'changePassword')->name('changePassword');
-        Route::put('{id}/subspend', 'subspendRole')->name('subspendRole');
+        Route::put('{id}/suspend', 'suspendRole')->name('suspendRole');
         Route::put('{id}', 'updateRole')->name('updateRole');
         Route::delete('{id}', 'deleteRole')->name('deleteRole');
     });
diff --git a/contexts/Authorization/Presentation/Controllers/RoleController.php b/contexts/Authorization/Presentation/Controllers/RoleController.php
@@ -58,10 +58,10 @@ public function updateRole(UpdateRoleRequest $request)
             ->send();
     }
 
-    public function subspendRole(RoleIdRequest $request)
+    public function suspendRole(RoleIdRequest $request)
     {
         $id = (int) ($request->validated()['id']);
-        $result = app(RoleCoordinator::class)->subspendRole($id);
+        $result = app(RoleCoordinator::class)->suspendRole($id);
 
         return $this->success(['id' => $result->getId()->getValue()])
             ->message('Role suspended successfully')
diff --git a/contexts/Authorization/Presentation/Controllers/UserIdentityController.php b/contexts/Authorization/Presentation/Controllers/UserIdentityController.php
@@ -60,10 +60,10 @@ public function updateUser(UpdateUserRequest $request)
             ->send();
     }
 
-    public function subspendUser(UserIdRequest $request)
+    public function suspendUser(UserIdRequest $request)
     {
         $id = (int) ($request->validated()['id']);
-        $result = app(UserIdentityCoordinator::class)->subspendUser($id);
+        $result = app(UserIdentityCoordinator::class)->suspendUser($id);
 
         return $this->success(['id' => $result->getId()->getValue()])
             ->message('User suspended successfully')
diff --git a/contexts/Authorization/Tests/Feature/Infrastructure/Persistence/RolePersistenceTest.php b/contexts/Authorization/Tests/Feature/Infrastructure/Persistence/RolePersistenceTest.php
@@ -161,15 +161,15 @@
         'PHP Tutorial',
         new CarbonImmutable
     );
-    $role2->subspend();
+    $role2->suspend();
     $rolePersistence->create($role2);
 
     $role3 = $this->roleFactory->create(
         RoleId::null(),
         'Laravel Tips',
         new CarbonImmutable
     );
-    $role3->subspend();
+    $role3->suspend();
     $rolePersistence->create($role3);
 
     // Test search by label criteria
diff --git a/contexts/Authorization/Tests/Feature/Infrastructure/Persistence/UserPersistenceTest.php b/contexts/Authorization/Tests/Feature/Infrastructure/Persistence/UserPersistenceTest.php
@@ -167,7 +167,7 @@
         $password,
         'PHP Tutorial'
     );
-    $user2->subspend();
+    $user2->suspend();
     $userPersistence->create($user2);
 
     $user3Email = new Email('tips@laravel.com');
@@ -177,7 +177,7 @@
         $password,
         'Laravel Tips'
     );
-    $user3->subspend();
+    $user3->suspend();
     $userPersistence->create($user3);
 
     // Test search by display_name criteria
diff --git a/contexts/Authorization/Tests/Feature/RoleTest.php b/contexts/Authorization/Tests/Feature/RoleTest.php
@@ -141,7 +141,7 @@
     ]);
 });
 
-it('can subspend a role', function () {
+it('can suspend a role', function () {
     $response = $this->postJson('roles', [
         'label' => 'My Role',
         'status' => 'active',
@@ -151,7 +151,7 @@
 
     $id = $response->json('data.id');
 
-    $response = $this->putJson("roles/{$id}/subspend");
+    $response = $this->putJson("roles/{$id}/suspend");
 
     $response->assertStatus(200);
 });
diff --git a/contexts/Authorization/Tests/Feature/UserTest.php b/contexts/Authorization/Tests/Feature/UserTest.php
@@ -2,8 +2,8 @@
 
 declare(strict_types=1);
 
-use Contexts\Authorization\Infrastructure\Records\RoleRecord;
 use Contexts\Authorization\Domain\Policies\RolePolicy;
+use Contexts\Authorization\Infrastructure\Records\RoleRecord;
 
 beforeEach(function () {
     Config::set('policies.authorization', [
@@ -100,7 +100,7 @@
     ]);
 });
 
-it('can subspend a user via api', function () {
+it('can suspend a user via api', function () {
     $response = $this->postJson('users', [
         'email' => 'test@email.com',
         'password' => 'password123',
@@ -112,7 +112,7 @@
 
     $id = $response->json('data.id');
 
-    $response = $this->putJson("users/{$id}/subspend");
+    $response = $this->putJson("users/{$id}/suspend");
 
     $response->assertStatus(200);
 });
diff --git a/contexts/Authorization/Tests/Unit/Domain/Role/Models/RoleTest.php b/contexts/Authorization/Tests/Unit/Domain/Role/Models/RoleTest.php
@@ -104,19 +104,19 @@
     expect($category->releaseEvents())->toBeEmpty();
 });
 
-it('can subspend an category', function () {
+it('can suspend an category', function () {
     $category = $this->roleFactory->create(RoleId::fromInt(1), 'Label');
     $category->releaseEvents();
 
-    $category->subspend();
+    $category->suspend();
 
     expect($category->getStatus()->equals(RoleStatus::suspended()))->toBeTrue();
-    expect($category->releaseEvents())->toBeEmpty(); // No events for subspending
+    expect($category->releaseEvents())->toBeEmpty(); // No events for suspending
 });
 
 it('can delete an category', function () {
     $category = $this->roleFactory->create(RoleId::fromInt(1), 'Label');
-    $category->subspend();
+    $category->suspend();
     $category->releaseEvents();
 
     $category->delete();
diff --git a/contexts/Authorization/Tests/Unit/Domain/UserIdentity/Models/UserIdentityTest.php b/contexts/Authorization/Tests/Unit/Domain/UserIdentity/Models/UserIdentityTest.php
@@ -251,7 +251,7 @@
     expect($user->releaseEvents())->toBeEmpty();
 });
 
-it('can subspend an user', function () {
+it('can suspend an user', function () {
     $user = $this->userFactory->create(
         UserId::fromInt(1),
         $this->email,
@@ -260,10 +260,10 @@
     );
     $user->releaseEvents();
 
-    $user->subspend();
+    $user->suspend();
 
     expect($user->getStatus()->equals(UserStatus::suspended()))->toBeTrue();
-    expect($user->releaseEvents())->toBeEmpty(); // No events for subspending
+    expect($user->releaseEvents())->toBeEmpty(); // No events for suspending
 });
 
 it('can delete an user', function () {
@@ -273,7 +273,7 @@
         $this->password,
         'DisplayName'
     );
-    $user->subspend();
+    $user->suspend();
     $user->releaseEvents();
 
     $user->delete();
@@ -572,7 +572,7 @@
         $this->password,
         'DisplayName'
     );
-    $user->subspend();
+    $user->suspend();
 
     $exception = null;
     try {
@@ -611,7 +611,7 @@
         $this->password,
         'DisplayName'
     );
-    $user->subspend();
+    $user->suspend();
 
     $exception = null;
     try {
diff --git a/contexts/CategoryManagement/Application/Coordinators/CategoryManagementCoordinator.php b/contexts/CategoryManagement/Application/Coordinators/CategoryManagementCoordinator.php
@@ -58,10 +58,10 @@ public function updateCategory(int $id, UpdateCategoryDTO $data): Category
         return $category;
     }
 
-    public function subspendCategory(int $id)
+    public function suspendCategory(int $id)
     {
         $category = $this->repository->getById(CategoryId::fromInt($id));
-        $category->subspend();
+        $category->suspend();
 
         $this->repository->update($category);
 
diff --git a/contexts/CategoryManagement/Domain/Models/Category.php b/contexts/CategoryManagement/Domain/Models/Category.php
@@ -60,7 +60,7 @@ public static function create(
         return $category;
     }
 
-    public function subspend()
+    public function suspend()
     {
         $this->transitionStatus(CategoryStatus::suspended());
     }
diff --git a/contexts/CategoryManagement/Infrastructure/Routes.php b/contexts/CategoryManagement/Infrastructure/Routes.php
@@ -10,7 +10,7 @@
         Route::get('{id}', 'getCategory')->name('getCategory');
         Route::get('', 'getCategoryList')->name('getCategoryList');
         Route::post('', 'createCategory')->name('createCategory');
-        Route::put('{id}/subspend', 'subspendCategory')->name('subspendCategory');
+        Route::put('{id}/suspend', 'suspendCategory')->name('suspendCategory');
         Route::put('{id}', 'updateCategory')->name('updateCategory');
         Route::delete('{id}', 'deleteCategory')->name('deleteCategory');
     });
diff --git a/contexts/CategoryManagement/Presentation/Controllers/CategoryManagementController.php b/contexts/CategoryManagement/Presentation/Controllers/CategoryManagementController.php
@@ -58,10 +58,10 @@ public function updateCategory(UpdateCategoryRequest $request)
             ->send();
     }
 
-    public function subspendCategory(CategoryIdRequest $request)
+    public function suspendCategory(CategoryIdRequest $request)
     {
         $id = (int) ($request->validated()['id']);
-        $result = app(CategoryManagementCoordinator::class)->subspendCategory($id);
+        $result = app(CategoryManagementCoordinator::class)->suspendCategory($id);
 
         return $this->success(['id' => $result->getId()->getValue()])
             ->message('Category suspended successfully')
diff --git a/contexts/CategoryManagement/Tests/Feature/CategoryTest.php b/contexts/CategoryManagement/Tests/Feature/CategoryTest.php
@@ -80,7 +80,7 @@
     ]);
 });
 
-it('can subspend a category', function () {
+it('can suspend a category', function () {
     $response = $this->postJson('categories', [
         'label' => 'My Category',
         'status' => 'active',
@@ -90,7 +90,7 @@
 
     $id = $response->json('data.id');
 
-    $response = $this->putJson("categories/{$id}/subspend");
+    $response = $this->putJson("categories/{$id}/suspend");
 
     $response->assertStatus(200);
 });
diff --git a/contexts/CategoryManagement/Tests/Feature/Infrastructure/Persistence/CategoryPersistenceTest.php b/contexts/CategoryManagement/Tests/Feature/Infrastructure/Persistence/CategoryPersistenceTest.php
@@ -127,15 +127,15 @@
         'PHP Tutorial',
         new CarbonImmutable
     );
-    $category2->subspend();
+    $category2->suspend();
     $categoryPersistence->create($category2);
 
     $category3 = Category::create(
         CategoryId::null(),
         'Laravel Tips',
         new CarbonImmutable
     );
-    $category3->subspend();
+    $category3->suspend();
     $categoryPersistence->create($category3);
 
     // Test search by label criteria
diff --git a/contexts/CategoryManagement/Tests/Unit/Domain/Models/CategoryTest.php b/contexts/CategoryManagement/Tests/Unit/Domain/Models/CategoryTest.php
@@ -94,19 +94,19 @@
     expect($category->releaseEvents())->toBeEmpty();
 });
 
-it('can subspend an category', function () {
+it('can suspend an category', function () {
     $category = Category::create(CategoryId::fromInt(1), 'Label');
     $category->releaseEvents();
 
-    $category->subspend();
+    $category->suspend();
 
     expect($category->getStatus()->equals(CategoryStatus::suspended()))->toBeTrue();
-    expect($category->releaseEvents())->toBeEmpty(); // No events for subspending
+    expect($category->releaseEvents())->toBeEmpty(); // No events for suspending
 });
 
 it('can delete an category', function () {
     $category = Category::create(CategoryId::fromInt(1), 'Label');
-    $category->subspend();
+    $category->suspend();
     $category->releaseEvents();
 
     $category->delete();

Original file line number	Diff line number	Diff line change
`@@ -78,14 +78,14 @@ public function updateRole(int $id, UpdateRoleDTO $data): Role`
`78`	`78`	`return $role;`
`79`	`79`	`}`
`80`	`80`
`81`		`- public function subspendRole(int $id)`
	`81`	`+ public function suspendRole(int $id)`
`82`	`82`	`{`
`83`	`83`	`CompositePolicy::allOf([`
`84`	`84`	`new GlobalPermissionPolicy('role.suspend'),`
`85`	`85`	`])->check();`
`86`	`86`
`87`	`87`	`$role = $this->repository->getById(RoleId::fromInt($id));`
`88`		`- $role->subspend();`
	`88`	`+ $role->suspend();`
`89`	`89`
`90`	`90`	`$this->repository->update($role);`
`91`	`91`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ public static function reconstitute(`
`61`	`61`	`return $role;`
`62`	`62`	`}`
`63`	`63`
`64`		`- public function subspend()`
	`64`	`+ public function suspend()`
`65`	`65`	`{`
`66`	`66`	`$this->transitionStatus(RoleStatus::suspended());`
`67`	`67`	`}`
Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ public static function createFromFactory(`
`136`	`136`	`return $user;`
`137`	`137`	`}`
`138`	`138`
`139`		`- public function subspend()`
	`139`	`+ public function suspend()`
`140`	`140`	`{`
`141`	`141`	`$this->transitionStatus(UserStatus::suspended());`
`142`	`142`	`}`
Original file line number	Diff line number	Diff line change
`@@ -58,10 +58,10 @@ public function updateRole(UpdateRoleRequest $request)`
`58`	`58`	`->send();`
`59`	`59`	`}`
`60`	`60`
`61`		`- public function subspendRole(RoleIdRequest $request)`
	`61`	`+ public function suspendRole(RoleIdRequest $request)`
`62`	`62`	`{`
`63`	`63`	`$id = (int) ($request->validated()['id']);`
`64`		`- $result = app(RoleCoordinator::class)->subspendRole($id);`
	`64`	`+ $result = app(RoleCoordinator::class)->suspendRole($id);`
`65`	`65`
`66`	`66`	`return $this->success(['id' => $result->getId()->getValue()])`
`67`	`67`	`->message('Role suspended successfully')`
Original file line number	Diff line number	Diff line change
`@@ -60,10 +60,10 @@ public function updateUser(UpdateUserRequest $request)`
`60`	`60`	`->send();`
`61`	`61`	`}`
`62`	`62`
`63`		`- public function subspendUser(UserIdRequest $request)`
	`63`	`+ public function suspendUser(UserIdRequest $request)`
`64`	`64`	`{`
`65`	`65`	`$id = (int) ($request->validated()['id']);`
`66`		`- $result = app(UserIdentityCoordinator::class)->subspendUser($id);`
	`66`	`+ $result = app(UserIdentityCoordinator::class)->suspendUser($id);`
`67`	`67`
`68`	`68`	`return $this->success(['id' => $result->getId()->getValue()])`
`69`	`69`	`->message('User suspended successfully')`