tv skip mask (#6)

* skip unsued mask

* add mask unused

* link

Author: TomasVotruba

.github/workflows/code_analysis.yaml

@@ -19,10 +19,6 @@ jobs:
                         name: 'Composer Validate'
                         run: composer validate --ansi
 
-                    -
-                        name: 'Rector'
-                        run: composer rector --ansi
-
                     -
                         name: 'Coding Standard'
                         run: composer fix-cs --ansi

src/Analyzer/UnusedDefinitionsAnalyzer.php

@@ -16,6 +16,9 @@
 use Symfony\Component\Console\Style\SymfonyStyle;
 use Symfony\Component\Finder\SplFileInfo;
 
+/**
+ * @see \Rector\Behastan\Tests\Analyzer\UnusedDefinitionsAnalyzer\UnusedDefinitionsAnalyzerTest
+ */
 final readonly class UnusedDefinitionsAnalyzer
 {
     /**
@@ -43,7 +46,6 @@ public function analyse(array $contextFiles, array $featureFiles): array
         $this->maskCollectionStatsPrinter->printStats($maskCollection);
 
         $featureInstructions = $this->usedInstructionResolver->resolveInstructionsFromFeatureFiles($featureFiles);
-
         $maskProgressBar = $this->symfonyStyle->createProgressBar($maskCollection->count());
 
         $unusedMasks = [];

src/DependencyInjection/ContainerFactory.php

@@ -50,9 +50,15 @@ public function create(): Container
             return $phpParserFactory->createForHostVersion();
         });
 
+        // silence in PHPUnit tests to keep output clear
+        $consoleOutput = new ConsoleOutput();
+        $consoleOutput->setVerbosity(
+            defined('PHPUNIT_COMPOSER_INSTALL') ? ConsoleOutput::VERBOSITY_QUIET : ConsoleOutput::VERBOSITY_NORMAL
+        );
+
         $container->singleton(
             SymfonyStyle::class,
-            static fn (): SymfonyStyle => new SymfonyStyle(new ArrayInput([]), new ConsoleOutput())
+            static fn (): SymfonyStyle => new SymfonyStyle(new ArrayInput([]), $consoleOutput)
         );
 
         return $container;

stubs/Behat/Behat/Context/Context.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Behat\Behat\Context;
+
+interface Context
+{
+}

tests/Analyzer/UnusedDefinitionsAnalyzer/Fixture/Contexts/SomeContext.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace Analyzer\UnusedDefinitionsAnalyzer\Fixture\Contexts;
+
+use Behat\Behat\Context\Context;
+use Behat\Step\Given;
+use Behat\Step\When;
+
+final class LoginContext implements Context
+{
+    #[Given('I am on the login page')]
+    public function iAmOnTheLoginPage(): void
+    {
+        // open login page
+    }
+
+    #[When('I login as :username')]
+    public function iLoginAs(string $username): void
+    {
+        // fill credentials and submit form
+    }
+
+    #[When('The :username is logged in')]
+    public function isLoggedIn(string $username): void
+    {
+        // fill credentials and submit form
+    }
+}

tests/Analyzer/UnusedDefinitionsAnalyzer/Fixture/Features/some.feature

@@ -0,0 +1,5 @@
+Feature: User login
+    Scenario: Successful login
+        Given I am on the login page
+        When I login as "Tomas"
+        Then The "Tomas" is logged in

tests/Analyzer/UnusedDefinitionsAnalyzer/UnusedDefinitionsAnalyzerTest.php

@@ -0,0 +1,34 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Behastan\Tests\Analyzer\UnusedDefinitionsAnalyzer;
+
+use Rector\Behastan\Analyzer\UnusedDefinitionsAnalyzer;
+use Rector\Behastan\Finder\BehatMetafilesFinder;
+use Rector\Behastan\Tests\AbstractTestCase;
+
+final class UnusedDefinitionsAnalyzerTest extends AbstractTestCase
+{
+    private UnusedDefinitionsAnalyzer $unusedDefinitionsAnalyzer;
+
+    protected function setUp(): void
+    {
+        parent::setUp();
+
+        $this->unusedDefinitionsAnalyzer = $this->make(UnusedDefinitionsAnalyzer::class);
+    }
+
+    public function test(): void
+    {
+        $featureFiles = BehatMetafilesFinder::findFeatureFiles([__DIR__ . '/Fixture/Features']);
+        $this->assertCount(1, $featureFiles);
+
+        $contextFiles = BehatMetafilesFinder::findContextFiles([__DIR__ . '/Fixture/Contexts']);
+        $this->assertCount(1, $contextFiles);
+
+        $unusedDefinitions = $this->unusedDefinitionsAnalyzer->analyse($contextFiles, $featureFiles);
+
+        $this->assertCount(0, $unusedDefinitions);
+    }
+}