misc

Author: TomasVotruba

src/Command/DuplicatedDefinitionsCommand.php

@@ -18,7 +18,6 @@ final class DuplicatedDefinitionsCommand extends Command
 {
     public function __construct(
         private readonly SymfonyStyle $symfonyStyle,
-        private readonly BehatMetafilesFinder $behatMetafilesFinder,
         private readonly ClassMethodContextDefinitionsAnalyzer $classMethodContextDefinitionsAnalyzer,
     ) {
         parent::__construct();
@@ -40,7 +39,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $testDirectory = (string) $input->getArgument('test-directory');
         Assert::directory($testDirectory);
 
-        $contextFileInfos = $this->behatMetafilesFinder->findContextFiles([$testDirectory]);
+        $contextFileInfos = BehatMetafilesFinder::findContextFiles([$testDirectory]);
 
         if ($contextFileInfos === []) {
             $this->symfonyStyle->error('No *.Context files found. Please provide correct test directory');

src/Command/StatsCommand.php

@@ -5,7 +5,6 @@
 namespace Behastan\Command;
 
 use Behastan\Analyzer\ClassMethodContextDefinitionsAnalyzer;
-use Behastan\DefinitionMasksResolver;
 use Behastan\Finder\BehatMetafilesFinder;
 use Behastan\UsedInstructionResolver;
 use Symfony\Component\Console\Command\Command;
@@ -19,8 +18,6 @@ final class StatsCommand extends Command
 {
     public function __construct(
         private readonly SymfonyStyle $symfonyStyle,
-        private readonly BehatMetafilesFinder $behatMetafilesFinder,
-        private readonly DefinitionMasksResolver $definitionMasksResolver,
         private readonly UsedInstructionResolver $usedInstructionResolver,
         private readonly ClassMethodContextDefinitionsAnalyzer $classMethodContextDefinitionsAnalyzer,
     ) {
@@ -45,25 +42,30 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $testDirectories = (array) $input->getArgument('test-directory');
         Assert::allDirectory($testDirectories);
 
-        $featureFiles = $this->behatMetafilesFinder->findFeatureFiles($testDirectories);
+        $featureFiles = BehatMetafilesFinder::findFeatureFiles($testDirectories);
         if ($featureFiles === []) {
             $this->symfonyStyle->error('No *.feature files found. Please provide correct test directory');
             return self::FAILURE;
         }
 
-        $contextFiles = $this->behatMetafilesFinder->findContextFiles($testDirectories);
+        $contextFiles = BehatMetafilesFinder::findContextFiles($testDirectories);
         if ($contextFiles === []) {
             $this->symfonyStyle->error('No *Context.php files found. Please provide correct test directory');
             return self::FAILURE;
         }
 
         $this->symfonyStyle->title('Usage stats for PHP definitions in *Feature files');
 
-        // $maskCollection = $this->definitionMasksResolver->resolve($contextFiles);
         $featureInstructions = $this->usedInstructionResolver->resolveInstructionsFromFeatureFiles($featureFiles);
 
         $classMethodContextDefinitions = $this->classMethodContextDefinitionsAnalyzer->resolve($contextFiles);
 
+        foreach ($classMethodContextDefinitions as $i => $classMethodContextDefinition) {
+            $section = sprintf('%d) %s', $i + 1, $classMethodContextDefinition->getMask());
+            $this->symfonyStyle->section($section);
+            $this->symfonyStyle->newLine();
+        }
+
         dump(123);
         die;
 

src/Command/UnusedDefinitionsCommand.php

@@ -18,7 +18,6 @@ final class UnusedDefinitionsCommand extends Command
 {
     public function __construct(
         private readonly SymfonyStyle $symfonyStyle,
-        private readonly BehatMetafilesFinder $behatMetafilesFinder,
         private readonly UnusedDefinitionsAnalyzer $unusedDefinitionsAnalyzer,
     ) {
         parent::__construct();
@@ -42,13 +41,13 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $testDirectories = (array) $input->getArgument('test-directory');
         Assert::allDirectory($testDirectories);
 
-        $featureFiles = $this->behatMetafilesFinder->findFeatureFiles($testDirectories);
+        $featureFiles = BehatMetafilesFinder::findFeatureFiles($testDirectories);
         if ($featureFiles === []) {
             $this->symfonyStyle->error('No *.feature files found. Please provide correct test directory');
             return self::FAILURE;
         }
 
-        $contextFiles = $this->behatMetafilesFinder->findContextFiles($testDirectories);
+        $contextFiles = BehatMetafilesFinder::findContextFiles($testDirectories);
         if ($contextFiles === []) {
             $this->symfonyStyle->error('No *Context.php files found. Please provide correct test directory');
             return self::FAILURE;

src/Finder/BehatMetafilesFinder.php

@@ -14,7 +14,7 @@ final class BehatMetafilesFinder
      * @param string[] $directories
      * @return SplFileInfo[]
      */
-    public function findContextFiles(array $directories): array
+    public static function findContextFiles(array $directories): array
     {
         Assert::allString($directories);
         Assert::allDirectory($directories);
@@ -32,7 +32,7 @@ public function findContextFiles(array $directories): array
      *
      * @return SplFileInfo[]
      */
-    public function findFeatureFiles(array $directories): array
+    public static function findFeatureFiles(array $directories): array
     {
         Assert::allString($directories);
         Assert::allDirectory($directories);