add line to unused definitino, to easier removal

Author: TomasVotruba

src/Analyzer/UnusedDefinitionsAnalyzer.php

@@ -4,7 +4,6 @@
 
 namespace Rector\Behastan\Analyzer;
 
-use Nette\Utils\Strings;
 use Rector\Behastan\DefinitionMasksResolver;
 use Rector\Behastan\Reporting\MaskCollectionStatsPrinter;
 use Rector\Behastan\UsedInstructionResolver;

src/Command/UnusedDefinitionsCommand.php

@@ -90,7 +90,9 @@ private function printMask(AbstractMask $unusedMask): void
 
         // make path relative
         $relativeFilePath = str_replace(getcwd() . '/', '', $unusedMask->filePath);
-        $this->symfonyStyle->writeln($relativeFilePath);
+        $filePathWithLine = $relativeFilePath . ':' . $unusedMask->line;
+
+        $this->symfonyStyle->writeln($filePathWithLine);
         $this->symfonyStyle->newLine();
     }
 }

src/DefinitionMasksResolver.php

@@ -44,6 +44,7 @@ public function resolve(array $contextFiles): MaskCollection
                 $masks[] = new SkippedMask(
                     $rawMask,
                     $classMethodContextDefinition->getFilePath(),
+                    $classMethodContextDefinition->getMethodLine(),
                     $classMethodContextDefinition->getClass(),
                     $classMethodContextDefinition->getMethodName()
                 );
@@ -55,6 +56,7 @@ public function resolve(array $contextFiles): MaskCollection
                 $masks[] = new RegexMask(
                     $rawMask,
                     $classMethodContextDefinition->getFilePath(),
+                    $classMethodContextDefinition->getMethodLine(),
                     $classMethodContextDefinition->getClass(),
                     $classMethodContextDefinition->getMethodName()
                 );
@@ -67,6 +69,7 @@ public function resolve(array $contextFiles): MaskCollection
                 $masks[] = new NamedMask(
                     $rawMask,
                     $classMethodContextDefinition->getFilePath(),
+                    $classMethodContextDefinition->getMethodLine(),
                     $classMethodContextDefinition->getClass(),
                     $classMethodContextDefinition->getMethodName()
                 );
@@ -76,6 +79,7 @@ public function resolve(array $contextFiles): MaskCollection
             $masks[] = new ExactMask(
                 $rawMask,
                 $classMethodContextDefinition->getFilePath(),
+                $classMethodContextDefinition->getMethodLine(),
                 $classMethodContextDefinition->getClass(),
                 $classMethodContextDefinition->getMethodName()
             );
@@ -118,7 +122,8 @@ private function resolveMasksFromFiles(array $fileInfos): array
                         $fileInfo->getRealPath(),
                         $className,
                         $classMethod->name->toString(),
-                        $rawMask
+                        $rawMask,
+                        $classMethod->getStartLine()
                     );
                 }
             }

src/Resolver/ClassMethodMasksResolver.php

@@ -18,7 +18,7 @@ final class ClassMethodMasksResolver
     /**
      * @var string[]
      */
-    private const ATTRIBUTE_NAMES = ['Behat\Step\Then', 'Behat\Step\Given', 'Behat\Step\And'];
+    private const ATTRIBUTE_NAMES = ['Behat\Step\When', 'Behat\Step\Then', 'Behat\Step\Given', 'Behat\Step\And'];
 
     /**
      * @return string[]

src/ValueObject/ClassMethodContextDefinition.php

@@ -13,7 +13,7 @@ public function __construct(
         private readonly string $class,
         private readonly string $methodName,
         private readonly string $mask,
-        private readonly ?int $methodLine = null
+        private readonly int $methodLine
     ) {
     }
 
@@ -37,7 +37,7 @@ public function getMask(): string
         return $this->mask;
     }
 
-    public function getMethodLine(): ?int
+    public function getMethodLine(): int
     {
         return $this->methodLine;
     }

src/ValueObject/Mask/AbstractMask.php

@@ -9,6 +9,7 @@ abstract class AbstractMask implements MaskInterface
     public function __construct(
         public readonly string $mask,
         public readonly string $filePath,
+        public readonly int $line,
         public readonly string $className,
         public readonly string $methodName,
     ) {