add class enum

Author: TomasVotruba

rules/Rector/Class_/PhpSpecClassToPHPUnitClassRector.php

@@ -9,6 +9,7 @@
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Stmt\Class_;
 use Rector\PhpSpecToPHPUnit\Naming\PhpSpecRenaming;
+use Rector\PHPUnit\Enum\PHPUnitClassName;
 use Rector\Privatization\NodeManipulator\VisibilityManipulator;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -52,7 +53,7 @@ public function refactor(Node $node): ?Node
         // rename class and parent class
         $phpunitTestClassName = $this->phpSpecRenaming->createPHPUnitTestClassName($node);
         $node->name = new Identifier($phpunitTestClassName);
-        $node->extends = new FullyQualified('PHPUnit\Framework\TestCase');
+        $node->extends = new FullyQualified(PHPUnitClassName::TEST_CASE);
 
         $this->visibilityManipulator->makeFinal($node);
 

src/DocFactory.php

@@ -5,6 +5,7 @@
 namespace Rector\PhpSpecToPHPUnit;
 
 use PhpParser\Comment\Doc;
+use Rector\PhpSpecToPHPUnit\Enum\PHPUnitClassName;
 use Rector\PhpSpecToPHPUnit\ValueObject\ServiceMock;
 
 final class DocFactory
@@ -14,7 +15,7 @@ public static function createForMockAssign(ServiceMock $serviceMock): Doc
         $comment = sprintf(
             "/** @var \%s|\%s $%s */",
             $serviceMock->getMockClassName(),
-            'PHPUnit\Framework\MockObject\MockObject',
+            PHPUnitClassName::MOCK_OBJECT,
             $serviceMock->getVariableName() . 'Mock'
         );
 
@@ -27,7 +28,7 @@ public static function createForMockProperty(ServiceMock $serviceMock): Doc
             "/**%s * @var \%s|\%s%s */",
             PHP_EOL,
             $serviceMock->getMockClassName(),
-            'PHPUnit\Framework\MockObject\MockObject',
+            PHPUnitClassName::MOCK_OBJECT,
             PHP_EOL
         );
 

src/Enum/PHPUnitClassName.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PhpSpecToPHPUnit\Enum;
+
+final class PHPUnitClassName
+{
+    public const MOCK_OBJECT = 'PHPUnit\Framework\MockObject\MockObject';
+}

src/NodeFactory/LetMockNodeFactory.php

@@ -18,6 +18,7 @@
 use Rector\NodeNameResolver\NodeNameResolver;
 use Rector\PhpParser\Node\NodeFactory;
 use Rector\PhpSpecToPHPUnit\DocFactory;
+use Rector\PhpSpecToPHPUnit\Enum\PHPUnitClassName;
 use Rector\PhpSpecToPHPUnit\Exception\ShouldNotHappenException;
 use Rector\PhpSpecToPHPUnit\ValueObject\ServiceMock;
 
@@ -87,7 +88,7 @@ public function createMockPropertyAssignExpressions(array $params): array
 
     private function crateMockProperty(string $parameterName): Property
     {
-        $objectType = new ObjectType('PHPUnit\Framework\MockObject\MockObject');
+        $objectType = new ObjectType(PHPUnitClassName::MOCK_OBJECT);
         return $this->nodeFactory->createPrivatePropertyFromNameAndType($parameterName, $objectType);
     }