try entropy

Author: TomasVotruba

.github/workflows/code_analysis.yaml

@@ -56,7 +56,7 @@ jobs:
             # see https://github.com/shivammathur/setup-php
             -   uses: shivammathur/setup-php@v2
                 with:
-                    php-version: 8.2
+                    php-version: 8.3
                     coverage: none
 
             # composer install cache - https://github.com/ramsey/composer-install

.github/workflows/downgraded_release.yaml

@@ -19,7 +19,7 @@ jobs:
             -
                 uses: "shivammathur/setup-php@v2"
                 with:
-                    php-version: 8.2
+                    php-version: 8.3
                     coverage: none
 
             # invoke patches

bin/jack.php

@@ -2,9 +2,7 @@
 
 declare(strict_types=1);
 
-use Symfony\Component\Console\Application;
-use Symfony\Component\Console\Input\ArgvInput;
-use Symfony\Component\Console\Output\ConsoleOutput;
+use Entropy\Console\ConsoleApplication;
 use Rector\Jack\DependencyInjection\ContainerFactory;
 
 $scoperAutoloadFilepath = __DIR__ . '/../vendor/scoper-autoload.php';
@@ -32,7 +30,7 @@
 $containerFactory = new ContainerFactory();
 $container = $containerFactory->create();
 
-$application = $container->make(Application::class);
+$consoleApplication = $container->make(ConsoleApplication::class);
 
-$exitCode = $application->run(new ArgvInput(), new ConsoleOutput());
+$exitCode = $consoleApplication->run($argv);
 exit($exitCode);

composer.json

@@ -6,12 +6,11 @@
         "bin/jack"
     ],
     "require": {
-        "php": ">=8.2",
+        "php": ">=8.3",
         "composer/semver": "^3.4",
-        "illuminate/container": "^12.37",
+        "entropy/entropy": "dev-main",
         "nette/utils": "^4.0",
         "symfony/console": "^6.4",
-        "symfony/finder": "^7.3",
         "symfony/process": "^7.3",
         "webmozart/assert": "^1.12"
     },
@@ -23,7 +22,6 @@
         "shipmonk/composer-dependency-analyser": "^1.8",
         "phpecs/phpecs": "^2.2",
         "symplify/phpstan-extensions": "^12.0",
-        "symplify/vendor-patches": "^11.5",
         "tomasvotruba/class-leak": "^2.0",
         "tracy/tracy": "^2.11"
     },
@@ -41,7 +39,6 @@
         "sort-packages": true,
         "platform-check": false,
         "allow-plugins": {
-            "cweagans/composer-patches": true,
             "phpstan/extension-installer": true
         }
     },

src/Command/BreakPointCommand.php

@@ -4,62 +4,39 @@
 
 namespace Rector\Jack\Command;
 
+use Entropy\Console\Contract\CommandInterface;
+use Entropy\Console\ValueObject\ArgumentsAndOptions;
 use Nette\Utils\Json;
+use Rector\Console\ExitCode;
 use Rector\Jack\Composer\ComposerOutdatedResponseProvider;
 use Rector\Jack\Enum\ComposerKey;
 use Rector\Jack\OutdatedComposerFactory;
-use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
-use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
 
-final class BreakPointCommand extends Command
+final readonly class BreakPointCommand implements CommandInterface
 {
     public function __construct(
-        private readonly OutdatedComposerFactory $outdatedComposerFactory,
-        private readonly ComposerOutdatedResponseProvider $composerOutdatedResponseProvider
+        private SymfonyStyle $symfonyStyle,
+        private OutdatedComposerFactory $outdatedComposerFactory,
+        private ComposerOutdatedResponseProvider $composerOutdatedResponseProvider
     ) {
-        parent::__construct();
     }
 
-    protected function configure(): void
+    public function run(ArgumentsAndOptions $argumentsAndOptions): int
     {
-        $this->setName('breakpoint');
-
-        $this->setDescription('Let your CI tell you, if there is too many major-version outdated packages');
-        $this->addOption('dev', null, InputOption::VALUE_NONE, 'Focus on dev packages only');
-
-        $this->addOption(
-            'limit',
-            null,
-            InputOption::VALUE_REQUIRED,
-            'Maximum number of outdated major version packages',
-            5
-        );
-
-        $this->addOption(
-            'ignore',
-            null,
-            InputOption::VALUE_IS_ARRAY | InputOption::VALUE_OPTIONAL,
-            'Ignore packages by name, e.g. "symfony/" or "symfony/console"',
-        );
-    }
-
-    protected function execute(InputInterface $input, OutputInterface $output): int
-    {
-        $symfonyStyle = new SymfonyStyle($input, $output);
+        //        $symfonyStyle = new SymfonyStyle($input, $output);
 
         $maxOutdatePackages = (int) $input->getOption('limit');
         $onlyDev = (bool) $input->getOption('dev');
 
-        $symfonyStyle->writeln('<fg=green>Analyzing "composer.json" for major outdated packages</>');
+        $this->symfonyStyle->writeln('<fg=green>Analyzing "composer.json" for major outdated packages</>');
 
         $responseJsonContents = $this->composerOutdatedResponseProvider->provide();
 
         $responseJson = Json::decode($responseJsonContents, true);
         if (! isset($responseJson[ComposerKey::INSTALLED_KEY])) {
-            $symfonyStyle->success('All packages are up to date');
+            $this->symfonyStyle->success('All packages are up to date');
 
             return self::SUCCESS;
         }
@@ -82,11 +59,11 @@ static function (array $package) use ($input): bool {
         );
 
         if ($outdatedComposer->count() === 0) {
-            $symfonyStyle->success('All packages are up to date');
+            $this->symfonyStyle->success('All packages are up to date');
             return self::SUCCESS;
         }
 
-        $symfonyStyle->title(
+        $this->symfonyStyle->title(
             sprintf(
                 'Found %d outdated package%s',
                 $outdatedComposer->count($onlyDev),
@@ -95,57 +72,87 @@ static function (array $package) use ($input): bool {
         );
 
         foreach ($outdatedComposer->getPackages($onlyDev) as $outdatedPackage) {
-            $symfonyStyle->writeln(
+            $this->symfonyStyle->writeln(
                 sprintf('The "<fg=green>%s</>" package is outdated', $outdatedPackage->getName())
             );
 
             if ($outdatedPackage->getCurrentVersionAge()) {
-                $symfonyStyle->writeln(sprintf(
+                $this->symfonyStyle->writeln(sprintf(
                     ' * Your version %s is <fg=%s>%s</>',
                     $outdatedPackage->getCurrentVersion(),
                     $outdatedPackage->isVeryOld() ? 'red' : 'yellow',
                     $outdatedPackage->getCurrentVersionAge(),
                 ));
             } else {
                 // composer 2.7- compatible
-                $symfonyStyle->writeln(sprintf(' * Your version is %s', $outdatedPackage->getCurrentVersion()));
+                $this->symfonyStyle->writeln(sprintf(' * Your version is %s', $outdatedPackage->getCurrentVersion()));
             }
 
-            $symfonyStyle->writeln(sprintf(' * Bump to %s', $outdatedPackage->getLatestVersion()));
-            $symfonyStyle->newLine();
+            $this->symfonyStyle->writeln(sprintf(' * Bump to %s', $outdatedPackage->getLatestVersion()));
+            $this->symfonyStyle->newLine();
         }
 
-        $symfonyStyle->newLine();
+        $this->symfonyStyle->newLine();
         if ($outdatedComposer->count() >= $maxOutdatePackages) {
             // to much → fail
-            $symfonyStyle->error(sprintf(
+            $this->symfonyStyle->error(sprintf(
                 'There %s %d outdated package%s. Update couple of them to get under %d limit',
                 $outdatedComposer->count() > 1 ? 'are' : 'is',
                 $outdatedComposer->count(),
                 $outdatedComposer->count() > 1 ? 's' : '',
                 $maxOutdatePackages
             ));
 
-            return self::FAILURE;
+            return ExitCode::FAILURE;
         }
 
         if ($outdatedComposer->count() > max(1, $maxOutdatePackages - 5)) {
             // to much → fail
-            $symfonyStyle->warning(sprintf(
+            $this->symfonyStyle->warning(sprintf(
                 'There are %d outdated packages. Soon, the count will go over %d limit and this job will fail.%sUpgrade in time',
                 $outdatedComposer->count(),
                 $maxOutdatePackages,
                 PHP_EOL
             ));
 
-            return self::SUCCESS;
+            return ExitCode::SUCCESS;
         }
 
         // to many → fail
-        $symfonyStyle->success(
+        $this->symfonyStyle->success(
             sprintf('Still far away from limit %d. Good job keeping your project up to date!', $maxOutdatePackages)
         );
 
-        return self::SUCCESS;
+        return ExitCode::SUCCESS;
+    }
+
+    public function getName(): string
+    {
+        return 'breakpoint';
+    }
+
+    public function getDescription(): string
+    {
+        return 'Let your CI tell you, if there is too many major-version outdated packages';
+    }
+
+    private function configure(): void
+    {
+        $this->addOption('dev', null, InputOption::VALUE_NONE, 'Focus on dev packages only');
+
+        $this->addOption(
+            'limit',
+            null,
+            InputOption::VALUE_REQUIRED,
+            'Maximum number of outdated major version packages',
+            5
+        );
+
+        $this->addOption(
+            'ignore',
+            null,
+            InputOption::VALUE_IS_ARRAY | InputOption::VALUE_OPTIONAL,
+            'Ignore packages by name, e.g. "symfony/" or "symfony/console"',
+        );
     }
 }