make use of 1 week project cache

Author: TomasVotruba

src/Composer/ComposerOutdatedResponseProvider.php

@@ -4,17 +4,20 @@
 
 namespace Rector\Jack\Composer;
 
+use Nette\Utils\DateTime;
 use Nette\Utils\FileSystem;
 use Symfony\Component\Process\Process;
 
 final class ComposerOutdatedResponseProvider
 {
     public function provide(): string
     {
-        // load from cache, temporarily - @todo cache on json hash + week timeout
-        $outdatedFilename = __DIR__ . '/../../dumped-outdated.json';
-        if (is_file($outdatedFilename)) {
-            return FileSystem::read($outdatedFilename);
+        $composerOutdatedFilePath = $this->resolveComposerOutdatedFilePath();
+
+        // let's use cache
+        if ($this->shouldLoadCacheFile($composerOutdatedFilePath)) {
+            /** @var string $composerOutdatedFilePath */
+            return FileSystem::read($composerOutdatedFilePath);
         }
 
         $composerOutdatedProcess = Process::fromShellCommandline(
@@ -23,9 +26,60 @@ public function provide(): string
         );
 
         $composerOutdatedProcess->mustRun();
+
         $processResult = $composerOutdatedProcess->getOutput();
 
-        FileSystem::write($outdatedFilename, $processResult);
+        if (is_string($composerOutdatedFilePath)) {
+            FileSystem::write($composerOutdatedFilePath, $processResult);
+        }
+
         return $processResult;
     }
+
+    private function resolveProjectComposerHash(): ?string
+    {
+        if (file_exists(getcwd() . '/composer.lock')) {
+            return sha1(getcwd() . '/composer.lock');
+        }
+
+        if (file_exists(getcwd() . '/composer.json')) {
+            return getcwd() . '/composer.json';
+        }
+
+        return null;
+    }
+
+    private function resolveComposerOutdatedFilePath(): ?string
+    {
+        $projectComposerHash = $this->resolveProjectComposerHash();
+        if ($projectComposerHash) {
+            // load from cache, temporarily - @todo cache on json hash + week timeout
+            return sys_get_temp_dir() . '/jack/composer-outdated-' . $projectComposerHash . '.json';
+        }
+
+        return null;
+    }
+
+    private function isFileYoungerThanWeek(string $filePath): bool
+    {
+        $fileTime = filemtime($filePath);
+        if ($fileTime === false) {
+            return false;
+        }
+
+        return (time() - $fileTime) < DateTime::WEEK;
+    }
+
+    private function shouldLoadCacheFile(?string $cacheFilePath): bool
+    {
+        if (! is_string($cacheFilePath)) {
+            return false;
+        }
+
+        if (! file_exists($cacheFilePath)) {
+            return false;
+        }
+
+        return $this->isFileYoungerThanWeek($cacheFilePath);
+    }
 }

src/Composer/NextVersionResolver.php

@@ -11,14 +11,14 @@
 /**
  * @see \Rector\Jack\Tests\Composer\NextVersionResolver\NextVersionResolverTest
  */
-final class NextVersionResolver
+final readonly class NextVersionResolver
 {
     private const MAJOR = 'major';
 
     private const MINOR = 'minor';
 
     public function __construct(
-        private readonly VersionParser $versionParser
+        private VersionParser $versionParser
     ) {
     }
 

src/DependencyInjection/ContainerFactory.php

@@ -24,20 +24,20 @@ public function create(): Container
 
         // console
         $container->singleton(Application::class, function (Container $container): Application {
-            $application = new JackConsoleApplication('Rector Jack');
+            $jackConsoleApplication = new JackConsoleApplication('Rector Jack');
 
             $commandClasses = $this->findCommandClasses();
 
             // register commands
             foreach ($commandClasses as $commandClass) {
                 $command = $container->make($commandClass);
-                $application->add($command);
+                $jackConsoleApplication->add($command);
             }
 
             // remove basic command to make output clear
-            $this->hideDefaultCommands($application);
+            $this->hideDefaultCommands($jackConsoleApplication);
 
-            return $application;
+            return $jackConsoleApplication;
         });
 
         $container->singleton(

src/ValueObject/OutdatedComposer.php

@@ -66,11 +66,7 @@ public function getPackagesShuffled(bool $onlyDev = false): array
     {
         // adds random effect, not to always update by A-Z, as would force too narrow pattern
         // this is also more fun :)
-        if ($onlyDev) {
-            $outdatedPackages = $this->getDevPackages();
-        } else {
-            $outdatedPackages = $this->outdatedPackages;
-        }
+        $outdatedPackages = $onlyDev ? $this->getDevPackages() : $this->outdatedPackages;
 
         shuffle($outdatedPackages);