Skip to content

Commit ba53887

Browse files
authored
skip dev- in open-versions command (#11)
1 parent e01da56 commit ba53887

File tree

3 files changed

+35
-2
lines changed

3 files changed

+35
-2
lines changed

src/ComposerProcessor/OpenVersionsComposerProcessor.php

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ public function process(
3434
foreach ($outdatedPackages as $outdatedPackage) {
3535
$composerVersion = $outdatedPackage->getComposerVersion();
3636

37-
// already filled with open version
38-
if (str_contains($composerVersion, '|')) {
37+
if ($this->skipExistingVersion($composerVersion)) {
3938
continue;
4039
}
4140

@@ -64,4 +63,14 @@ public function process(
6463

6564
return new ChangedPackageVersionsResult($composerJsonContents, $openedPackages);
6665
}
66+
67+
private function skipExistingVersion(string $composerVersion): bool
68+
{
69+
// already filled with open version
70+
if (str_contains($composerVersion, '|')) {
71+
return true;
72+
}
73+
74+
return str_contains($composerVersion, 'dev-');
75+
}
6776
}
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"require": {
3+
"symfony/console": "dev-test"
4+
}
5+
}

tests/ComposerProcessor/OpenVersionsComposerProcessor/OpenVersionsComposerProcessorTest.php

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,23 @@ public function test(): void
4949
$changedPackageVersionsResult->getComposerJsonContents()
5050
);
5151
}
52+
53+
public function testSkipDev(): void
54+
{
55+
$composerJsonContents = FileSystem::read(__DIR__ . '/Fixture/skip-dev.json');
56+
57+
$outdatedComposer = new OutdatedComposer([
58+
new OutdatedPackage('symfony/console', '5.4.0', 'dev-main', true, '6.4.0', '1 year'),
59+
]);
60+
61+
$changedPackageVersionsResult = $this->openVersionsComposerProcessor->process(
62+
$composerJsonContents,
63+
$outdatedComposer,
64+
10,
65+
false,
66+
null
67+
);
68+
69+
$this->assertEmpty($changedPackageVersionsResult->getChangedPackageVersions());
70+
}
5271
}

0 commit comments

Comments
 (0)