misc

Author: TomasVotruba

.github/workflows/code_analysis.yaml

@@ -32,6 +32,10 @@ jobs:
                         name: 'Jack: Outdated Breakpoint'
                         run: ./bin/jack breakpoint --limit 3
 
+                    -
+                        name: "Commented Code"
+                        run: vendor/bin/swiss-knife check-commented-code src tests --ansi
+
                     -
                         name: 'Jack: Open Versions'
                         run: ./bin/jack open-versions --dry-run
@@ -45,7 +49,7 @@ jobs:
                         run: vendor/bin/class-leak check bin src tests --ansi --skip-type="\Entropy\Console\Contract\CommandInterface"
 
                     -
-                        name: 'Unusued check'
+                        name: 'Composer Dependency Analyser'
                         run: vendor/bin/composer-dependency-analyser
 
         name: ${{ matrix.actions.name }}

composer.json

@@ -14,12 +14,13 @@
         "webmozart/assert": "^2.0"
     },
     "require-dev": {
+        "phpecs/phpecs": "^2.2",
         "phpstan/extension-installer": "^1.4",
         "phpstan/phpstan": "^2.1",
         "phpunit/phpunit": "^12.5",
         "rector/rector": "^2.2",
+        "rector/swiss-knife": "^2.3",
         "shipmonk/composer-dependency-analyser": "^1.8",
-        "phpecs/phpecs": "^2.2",
         "symplify/phpstan-extensions": "^12.0",
         "tomasvotruba/class-leak": "^2.1",
         "tracy/tracy": "^2.11"

src/Command/OpenVersionsCommand.php

@@ -80,13 +80,7 @@ public function run(int $limit = 5, bool $dryRun = false, bool $dev = false, ?st
             $outdatedComposer->getDevPackagesCount() === 1 ? '' : 's'
         ), 1);
 
-        // @todo
-        // $this->outputPrinter->title('Opening version constraints in "composer.json"');
-
-        //        $limit = (int) $input->getOption('limit');
-        //        $dryRun = (bool) $input->getOption('dry-run');
-        //        $onlyDev = (bool) $input->getOption('dev');
-        //        $packagePrefix = $input->getOption('package-prefix');
+        $this->outputPrinter->writeln('Opening version constraints in "composer.json"');
 
         $composerJsonContents = FileSystem::read($composerJsonFilePath);
 

src/DependencyInjection/ContainerFactory.php

@@ -8,20 +8,11 @@
 
 final class ContainerFactory
 {
-    /**
-     * @api used in bin and tests
-     */
     public function create(): Container
     {
         $container = new Container();
-
         $container->autodiscover(__DIR__ . '/../../src');
 
-        //        $container->service(CommandRegistry::class, function (Container $container): CommandRegistry {
-        //            $commands = $container->findByContract(CommandInterface::class);
-        //            return new CommandRegistry($commands);
-        //        });
-
         return $container;
     }
 }