kick off laravel rector, php-parser 5.4 and phpunit 11 test using getArg() calls on CallLike

Author: TomasVotruba

.github/workflows/rector_laravel_php_parser.yaml.yml

@@ -0,0 +1,27 @@
+# see https://github.com/rectorphp/rector/issues/9470#issuecomment-3453388719
+name: Rector Laravel and PHP Parser
+
+on:
+    pull_request: null
+    push:
+        branches:
+            - main
+
+jobs:
+    compat_tests:
+        runs-on: ubuntu-latest
+
+        steps:
+            -   uses: actions/checkout@v4
+
+            -
+                uses: shivammathur/setup-php@v2
+                with:
+                    php-version: "8.1"
+                    coverage: none
+
+            -   uses: "ramsey/composer-install@v2"
+
+            -   run: composer require "phpunit/phpunit:11.*" -W
+
+            -   run: vendor/bin/rector p fixture --debug --clear-cache

composer.json

@@ -6,7 +6,8 @@
         "phpunit/phpunit": "10.*|11.*|12.*",
         "nikic/php-parser": "5.4.*",
         "rector/rector": "dev-main",
-        "phpstan/phpstan": "^2.1"
+        "phpstan/phpstan": "2.1.*",
+        "driftingly/rector-laravel": "^0.27.0"
     },
     "autoload": {
         "psr-4": {
@@ -15,7 +16,8 @@
     },
     "autoload-dev": {
         "psr-4": {
-            "Rector\\RectorCompatTests\\Tests\\": "tests"
+            "Rector\\RectorCompatTests\\Tests\\": "tests",
+            "Fixture\\": "fixture"
         }
     }
 }

fixture/FixtureWithFuncCall.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Fixture;
+
+final class FixtureWithFuncCall
+{
+    public function run(): int
+    {
+        return strlen('hello');
+    }
+}

rector.php

@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\RectorCompatTests\Rector\UseGetArgRector;
+
+return RectorConfig::configure()
+    ->withPaths([
+        __DIR__ . '/src',
+        __DIR__ . '/tests',
+        __DIR__ . '/fixture',
+    ])
+    // uncomment to reach your current PHP version
+    // ->withPhpSets()
+   ->withRules([UseGetArgRector::class])
+    ->withTypeCoverageLevel(0)
+    ->withDeadCodeLevel(0)
+    ->withCodeQualityLevel(0);

src/Rector/UseGetArgRector.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\RectorCompatTests\Rector;
+
+use PhpParser\Modifiers;
+use PhpParser\Node;
+use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Stmt\Class_;
+use PhpParser\Node\Stmt\Function_;
+use Rector\Rector\AbstractRector;
+
+final class UseGetArgRector extends AbstractRector
+{
+    /**
+     * @return array<class-string<Class_>>
+     */
+    public function getNodeTypes(): array
+    {
+        return [FuncCall::class];
+    }
+
+    /**
+     * @param FuncCall $node
+     */
+    public function refactor(Node $node)
+    {
+        // here we should load Rector's php-parser 5.6, that already has getArg() method
+
+        return $node->getArg('name', 5);
+    }
+}