Support Param nodes in makeNonFinal()

Arshid · Arshid · commit 008d166f9e95 · 2025-09-08T01:11:05.000+05:30
diff --git a/rules/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector.php b/rules/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector.php
@@ -5,7 +5,6 @@
 namespace Rector\DowngradePhp85\Rector\Class_;
 
 use PhpParser\Builder\Property;
-use PhpParser\Modifiers;
 use PhpParser\Node;
 use PhpParser\Node\Param;
 use PhpParser\Node\Stmt\ClassMethod;
@@ -88,6 +87,7 @@ public function refactor(Node $node): null
             if (! $param->isPromoted()) {
                 continue;
             }
+
             if (! $this->visibilityManipulator->hasVisibility($param, Visibility::FINAL)) {
                 continue;
             }

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,6 @@`
`5`	`5`	`namespace Rector\DowngradePhp85\Rector\Class_;`
`6`	`6`
`7`	`7`	`use PhpParser\Builder\Property;`
`8`		`-use PhpParser\Modifiers;`
`9`	`8`	`use PhpParser\Node;`
`10`	`9`	`use PhpParser\Node\Param;`
`11`	`10`	`use PhpParser\Node\Stmt\ClassMethod;`
`@@ -88,6 +87,7 @@ public function refactor(Node $node): null`
`88`	`87`	`if (! $param->isPromoted()) {`
`89`	`88`	`continue;`
`90`	`89`	`}`
	`90`	`+`
`91`	`91`	`if (! $this->visibilityManipulator->hasVisibility($param, Visibility::FINAL)) {`
`92`	`92`	`continue;`
`93`	`93`	`}`