skip casted bool

Author: samsonasik

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/skip_casted_bool.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class SkipCastedBool
+{
+    public function run(string $name)
+    {
+        return (bool) substr($name, 2);
+    }
+}

rules/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector.php

@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\BooleanNot;
+use PhpParser\Node\Expr\Cast;
 use PhpParser\Node\Expr\Cast\String_;
 use PhpParser\Node\Expr\Empty_;
 use PhpParser\Node\Expr\FuncCall;
@@ -39,15 +40,15 @@ public function getRuleDefinition(): RuleDefinition
      */
     public function getNodeTypes(): array
     {
-        return [String_::class, Empty_::class, BooleanNot::class, Ternary::class, FuncCall::class];
+        return [Cast::class, Empty_::class, BooleanNot::class, Ternary::class, FuncCall::class];
     }
 
     /**
-     * @param String_|Empty_|BooleanNot|Ternary|FuncCall $node
+     * @param Cast|Empty_|BooleanNot|Ternary|FuncCall $node
      */
     public function refactor(Node $node): ?Node
     {
-        if ($node instanceof String_ || $node instanceof Empty_ || $node instanceof BooleanNot) {
+        if ($node instanceof Cast || $node instanceof Empty_ || $node instanceof BooleanNot) {
             $node->expr->setAttribute(self::IS_UNCASTABLE, true);
             return null;
         }