Remove Core namespace (#210)

* Remove Core namespace

* tidy up phpstan

* misc

* fix type

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <[email protected]>

Author: TomasVotruba

composer.json

@@ -9,22 +9,17 @@
     "require-dev": {
         "phpstan/extension-installer": "^1.3",
         "phpstan/phpstan": "^1.10",
-        "phpstan/phpstan-deprecation-rules": "^1.1",
         "phpstan/phpstan-webmozart-assert": "^1.2",
         "phpunit/phpunit": "^10.3",
-        "rector/phpstan-rules": "^0.7",
+        "rector/phpstan-rules": "^0.7.4",
         "rector/rector-generator": "^0.7.3",
         "rector/rector-src": "dev-main",
-        "symplify/easy-ci": "^11.2",
         "symplify/easy-coding-standard": "^12.0",
         "symplify/phpstan-extensions": "^11.3",
-        "symplify/phpstan-rules": "^12.0",
+        "symplify/phpstan-rules": "^12.4",
         "symplify/rule-doc-generator": "^12.0",
         "symplify/vendor-patches": "^11.2",
-        "tomasvotruba/class-leak": "^0.1",
-        "tomasvotruba/cognitive-complexity": "^0.1",
-        "tomasvotruba/type-coverage": "^0.2",
-        "tomasvotruba/unused-public": "^0.2",
+        "tomasvotruba/class-leak": "^0.2",
         "tracy/tracy": "^2.10"
     },
     "autoload": {

config/set/downgrade-php72.php

@@ -3,7 +3,7 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-use Rector\Core\ValueObject\PhpVersion;
+use Rector\ValueObject\PhpVersion;
 use Rector\DowngradePhp72\Rector\ClassMethod\DowngradeParameterTypeWideningRector;
 use Rector\DowngradePhp72\Rector\ConstFetch\DowngradePhp72JsonConstRector;
 use Rector\DowngradePhp72\Rector\FuncCall\DowngradeJsonDecodeNullAssociativeArgRector;

config/set/downgrade-php73.php

@@ -3,7 +3,7 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-use Rector\Core\ValueObject\PhpVersion;
+use Rector\ValueObject\PhpVersion;
 use Rector\DowngradePhp73\Rector\ConstFetch\DowngradePhp73JsonConstRector;
 use Rector\DowngradePhp73\Rector\FuncCall\DowngradeArrayKeyFirstLastRector;
 use Rector\DowngradePhp73\Rector\FuncCall\DowngradeIsCountableRector;

config/set/downgrade-php74.php

@@ -3,7 +3,7 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-use Rector\Core\ValueObject\PhpVersion;
+use Rector\ValueObject\PhpVersion;
 use Rector\DowngradePhp74\Rector\Array_\DowngradeArraySpreadRector;
 use Rector\DowngradePhp74\Rector\ArrowFunction\ArrowFunctionToAnonymousFunctionRector;
 use Rector\DowngradePhp74\Rector\ClassMethod\DowngradeContravariantArgumentTypeRector;

config/set/downgrade-php80.php

@@ -4,7 +4,7 @@
 use Rector\DowngradePhp80\Rector\ClassMethod\RemoveReturnTypeDeclarationFromCloneRector;
 
 use Rector\Config\RectorConfig;
-use Rector\Core\ValueObject\PhpVersion;
+use Rector\ValueObject\PhpVersion;
 use Rector\DowngradePhp80\Rector\ArrayDimFetch\DowngradeDereferenceableOperationRector;
 use Rector\DowngradePhp80\Rector\Catch_\DowngradeNonCapturingCatchesRector;
 use Rector\DowngradePhp80\Rector\Class_\DowngradeAttributeToAnnotationRector;

config/set/downgrade-php81.php

@@ -6,7 +6,7 @@
 use Rector\DowngradePhp81\Rector\LNumber\DowngradeOctalNumberRector;
 use Rector\DowngradePhp81\Rector\MethodCall\DowngradeIsEnumRector;
 use Rector\Config\RectorConfig;
-use Rector\Core\ValueObject\PhpVersion;
+use Rector\ValueObject\PhpVersion;
 use Rector\DowngradePhp81\Rector\Array_\DowngradeArraySpreadStringKeyRector;
 use Rector\DowngradePhp81\Rector\ClassConst\DowngradeFinalizePublicClassConstantRector;
 use Rector\DowngradePhp81\Rector\FuncCall\DowngradeArrayIsListRector;

config/set/downgrade-php82.php

@@ -3,7 +3,7 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-use Rector\Core\ValueObject\PhpVersion;
+use Rector\ValueObject\PhpVersion;
 use Rector\DowngradePhp82\Rector\Class_\DowngradeReadonlyClassRector;
 use Rector\DowngradePhp82\Rector\FunctionLike\DowngradeStandaloneNullTrueFalseReturnTypeRector;
 

phpstan.neon

@@ -16,27 +16,19 @@ parameters:
         - tests
         - rules-tests
 
-
     excludePaths:
         # tests files
         - "*/Expected/*"
         - '*/Fixture/*'
         - '*/Source/*'
 
-    cognitive_complexity:
-        class: 30
-        function: 10
-
     ignoreErrors:
         # php enum value minus
         - '#Parameter \#1 \$phpVersion of method Rector\\Config\\RectorConfig\:\:phpVersion\(\) expects (.*?), (.*?) given#'
 
         # part of implicit contract
         - '#Call to an undefined method PHPStan\\Type\\ConstantType\:\:getValue\(\)#'
 
-        # part of tests
-        - '#Class Rector\\Tests\\DowngradePhp72\\Rector\\ClassMethod\\DowngradeParameterTypeWideningRector\\Fixture\\SomeContainerInterface not found#'
-
         - '#Calling PHPStan\\Reflection\\Native\\NativeFunctionReflection\:\:getName\(\) is not covered by backward compatibility promise\. The method might change in a minor PHPStan version#'
 
         -
@@ -60,10 +52,6 @@ parameters:
             message: '#New objects with "\$returnType" name are overridden\. This can lead to unwanted bugs, please pick a different name to avoid it#'
             path: src/PhpDocDecorator/PhpDocFromTypeDeclarationDecorator.php
 
-        -
-            message: '#Class cognitive complexity is 32, keep it under 30#'
-            path: rules/DowngradePhp73/Rector/List_/DowngradeListReferenceAssignmentRector.php
-
         - '#Parameter \#3 \$stmt of method Rector\\DowngradePhp72\\Rector\\FuncCall\\DowngradePregUnmatchedAsNullConstantRector\:\:processReplace\(\) expects PhpParser\\Node\\Stmt, PhpParser\\Node given#'
 
         - '#(.*?)\:\:refactor\(\) should return array<PhpParser\\Node\\Stmt>\|PhpParser\\Node\\Stmt\\ClassConst\|null but returns array<PhpParser\\Node\\Stmt>\|PhpParser\\Node\\Stmt\|null#'
@@ -72,22 +60,9 @@ parameters:
             message: '#Use value object over return of values#'
             path: rules/DowngradePhp80/Rector/Expression/DowngradeThrowExprRector.php
 
-        -
-            message: '#Class cognitive complexity is \d+, keep it under 30#'
-            path: rules/DowngradePhp80/Rector/Expression/DowngradeMatchToSwitchRector.php
-
-        -
-            message: '#Cognitive complexity for "Rector\\DowngradePhp80\\Rector\\Expression\\DowngradeMatchToSwitchRector\:\:refactorWithScope\(\)" is 38, keep it under 10#'
-            path: rules/DowngradePhp80/Rector/Expression/DowngradeMatchToSwitchRector.php
-
         # phpstan need to load rector nodes first to avoid this
         - '#Rector\\Core\\Contract\\PhpParser\\Node\\StmtsAwareInterface#'
 
         -
             message: '#Parameter \#1 \$attributeClass of class Rector\\DowngradePhp80\\ValueObject\\DowngradeAttributeToAnnotation constructor expects class\-string, string given#'
             path: "config/*"
-
-        # we need exact types
-        - '#Doing instanceof PHPStan\\Type\\(.*?) is error\-prone and deprecated#'
-        # easier to run for simple cases
-        - '#Call to deprecated method getTypeFromValue\(\) of class PHPStan\\Type\\ConstantTypeHelper#'

rules-tests/DowngradePhp72/Rector/FunctionLike/DowngradeObjectTypeDeclarationRector/config/configured_rule.php

@@ -4,8 +4,8 @@
 
 use Rector\Config\RectorConfig;
 
-use Rector\Core\ValueObject\PhpVersionFeature;
 use Rector\DowngradePhp72\Rector\FunctionLike\DowngradeObjectTypeDeclarationRector;
+use Rector\ValueObject\PhpVersionFeature;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->rule(DowngradeObjectTypeDeclarationRector::class);

rules-tests/DowngradePhp74/Rector/ClassMethod/DowngradeCovariantReturnTypeRector/config/configured_rule.php

@@ -3,8 +3,8 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
-use Rector\Core\ValueObject\PhpVersionFeature;
 use Rector\DowngradePhp74\Rector\ClassMethod\DowngradeCovariantReturnTypeRector;
+use Rector\ValueObject\PhpVersionFeature;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->rule(DowngradeCovariantReturnTypeRector::class);