skip in binary op

Author: samsonasik

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/skip_in_binary_op.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class SkipInBinaryOp
+{
+    public function run($a)
+    {
+        return substr("a", 2) && $a === true;
+    }
+}

rules/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector.php

@@ -10,6 +10,7 @@
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node\Expr\AssignOp;
+use PhpParser\Node\Expr\BinaryOp;
 use PhpParser\Node\Expr\BinaryOp\Concat;
 use PhpParser\Node\Expr\BinaryOp\Identical;
 use PhpParser\Node\Expr\BooleanNot;
@@ -81,12 +82,13 @@ public function getNodeTypes(): array
             Do_::class,
             ArrayItem::class,
             ArrayDimFetch::class,
+            BinaryOp::class,
             FuncCall::class,
         ];
     }
 
     /**
-     * @param Cast|Empty_|BooleanNot|Ternary|Identical|Concat|MethodCall|StaticCall|AssignOp|If_|While_|Do_|ArrayItem|ArrayDimFetch|FuncCall $node
+     * @param Cast|Empty_|BooleanNot|Ternary|Identical|Concat|MethodCall|StaticCall|AssignOp|If_|While_|Do_|ArrayItem|ArrayDimFetch|BinaryOp|FuncCall $node
      */
     public function refactor(Node $node): ?Node
     {
@@ -142,6 +144,12 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        if ($node instanceof BinaryOp) {
+            $node->left->setAttribute(self::IS_UNCASTABLE, true);
+            $node->right->setAttribute(self::IS_UNCASTABLE, true);
+            return null;
+        }
+
         if ($node instanceof CallLike) {
             if ($node->isFirstClassCallable()) {
                 return null;