Optimize node type verification (#353)

TomasVotruba · web-flow · commit 1543cbec5627 · 2025-12-20T10:23:02.000+01:00
* dev

* misc
diff --git a/composer.json b/composer.json
@@ -11,7 +11,7 @@
         "phpstan/phpstan": "^2.1.32",
         "phpstan/phpstan-webmozart-assert": "^2.0",
         "phpunit/phpunit": "^11.5",
-        "rector/rector-src": "dev-main",
+        "rector/rector-src": "dev-tv-traverse-optimize",
         "rector/type-perfect": "^2.1",
         "symplify/easy-coding-standard": "^12.3",
         "symplify/phpstan-extensions": "^12.0",
diff --git a/rules/DowngradePhp73/Rector/ConstFetch/DowngradePhp73JsonConstRector.php b/rules/DowngradePhp73/Rector/ConstFetch/DowngradePhp73JsonConstRector.php
@@ -201,8 +201,7 @@ private function hasConstFetchInArgs(array $args, string $constName): bool
     {
         foreach ($args as $arg) {
             $value = $arg->value;
-
-            if ($value instanceof ConstFetch && $this->getName($value) === $constName) {
+            if ($value instanceof ConstFetch && $this->isName($value, $constName)) {
                 return true;
             }
 
diff --git a/tests/Issues/DowngradeNullJson/Fixture/fixture.php.inc b/tests/Issues/DowngradeNullJson/Fixture/fixture.php.inc
@@ -22,7 +22,7 @@ class Fixture
 {
     public function run(?int $flags = null)
     {
-        $flags = $flags ?? JSON_HEX_TAG | JSON_HEX_APOS | JSON_HEX_AMP | JSON_HEX_QUOT | JSON_PRESERVE_ZERO_FRACTION;
+        $flags = $flags ?? JSON_HEX_TAG | JSON_HEX_APOS | JSON_HEX_AMP | JSON_HEX_QUOT | JSON_PRESERVE_ZERO_FRACTION | 0;
 
         json_encode([], $flags);
     }

Original file line number	Diff line number	Diff line change
`@@ -201,8 +201,7 @@ private function hasConstFetchInArgs(array $args, string $constName): bool`
`201`	`201`	`{`
`202`	`202`	`foreach ($args as $arg) {`
`203`	`203`	`$value = $arg->value;`
`204`		`-`
`205`		`- if ($value instanceof ConstFetch && $this->getName($value) === $constName) {`
	`204`	`+ if ($value instanceof ConstFetch && $this->isName($value, $constName)) {`
`206`	`205`	`return true;`
`207`	`206`	`}`
`208`	`207`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ class Fixture`
`22`	`22`	`{`
`23`	`23`	`public function run(?int $flags = null)`
`24`	`24`	`{`
`25`		`- $flags = $flags ?? JSON_HEX_TAG \| JSON_HEX_APOS \| JSON_HEX_AMP \| JSON_HEX_QUOT \| JSON_PRESERVE_ZERO_FRACTION;`
	`25`	`+ $flags = $flags ?? JSON_HEX_TAG \| JSON_HEX_APOS \| JSON_HEX_AMP \| JSON_HEX_QUOT \| JSON_PRESERVE_ZERO_FRACTION \| 0;`
`26`	`26`
`27`	`27`	`json_encode([], $flags);`
`28`	`28`	`}`