Use rector-src#dev-upgrade-to-php-parser5-and-phpstan-2 (#235)

* Use rector-src#dev-upgrade-to-php-parser5-and-phpstan-2

* update to php-parser 5 nodes

* cs fix

* fix print return

* fix use Token as array

* fix use token as array on FollowedByCommaAnalyzer

* fix downgrade array spread

* [ci-review] Rector Rectify

* fix Throw_ as Expr on DowngradeThrowExprRector

* fix token as array on DowngradeDereferenceableOperationRector

* fix constant type on DowngradeNamedArgumentRector

* fix ParamTagValueNode usage on DowngradeEnumToConstantListClassRector

* fix throw as expr on ArrowFunctionToAnonymousFunctionRector

* [ci-review] Rector Rectify

* fix

* fix throw

* [ci-review] Rector Rectify

* fix downgrade json const and fix token as array

* fix fixture on DowngradeUnionTypeDeclarationRector

* fix constant type

* fixing phpstan

* [ci-review] Rector Rectify

* fix phpstan on DowngradeAttributeToAnnotationRector

* fix phpstan

* fix fixture

* handle doc indentation

* require dev phpstan webmozart v2 and fix phsptan message return

---------

Co-authored-by: GitHub Action <[email protected]>

Author: samsonasik

composer.json

@@ -8,14 +8,11 @@
     },
     "require-dev": {
         "phpstan/extension-installer": "^1.3",
-        "phpstan/phpstan": "^1.10",
-        "phpstan/phpstan-webmozart-assert": "^1.2",
+        "phpstan/phpstan": "^2.0",
+        "phpstan/phpstan-webmozart-assert": "^2.0",
         "phpunit/phpunit": "^10.5",
-        "rector/rector-src": "dev-main",
-        "rector/type-perfect": "^1.0",
+        "rector/rector-src": "dev-upgrade-to-php-parser5-and-phpstan-2",
         "symplify/easy-coding-standard": "^12.3",
-        "symplify/phpstan-extensions": "^11.4",
-        "symplify/phpstan-rules": "^13.0",
         "symplify/rule-doc-generator": "^12.2",
         "symplify/vendor-patches": "^11.3",
         "tomasvotruba/class-leak": "^1.0",
@@ -33,7 +30,7 @@
         "classmap": ["stubs"]
     },
     "scripts": {
-        "phpstan": "vendor/bin/phpstan analyse --ansi --error-format symplify",
+        "phpstan": "vendor/bin/phpstan analyse --ansi",
         "check-cs": "vendor/bin/ecs check --ansi",
         "fix-cs": "vendor/bin/ecs check --fix --ansi"
     },

phpstan.neon

@@ -1,6 +1,7 @@
-includes:
-    - vendor/symplify/phpstan-rules/config/symplify-rules.neon
-    - vendor/symplify/phpstan-rules/config/rector-rules.neon
+# to be enabled later once rector upgraded to use phpstan v2
+# includes:
+#    - vendor/symplify/phpstan-rules/config/symplify-rules.neon
+#    - vendor/symplify/phpstan-rules/config/rector-rules.neon
 
 parameters:
     level: 8
@@ -10,6 +11,8 @@ parameters:
     # requires exact closure types
     checkMissingCallableSignature: true
 
+    treatPhpDocTypesAsCertain: false
+
     paths:
         - src
         - config
@@ -24,11 +27,12 @@ parameters:
         - '*/Source/*'
 
     # see https://github.com/rectorphp/type-perfect/
-    type_perfect:
-        no_mixed: true
-        null_over_false: true
-        narrow_param: true
-        narrow_return: true
+# to be enabled later once rector upgraded to use phpstan v2
+#    type_perfect:
+#        no_mixed: true
+#        null_over_false: true
+#        narrow_param: true
+#        narrow_return: true
 
     ignoreErrors:
         # php enum value minus
@@ -55,3 +59,18 @@ parameters:
             message: '#Parameter \#1 \$attributeClass of class Rector\\DowngradePhp80\\ValueObject\\DowngradeAttributeToAnnotation constructor expects class\-string, string given#'
             path: "config/*"
 
+        # more advanced usage, but not always working
+        # see https://github.com/rectorphp/rector-src/actions/runs/11798721617/job/32865546672?pr=6422#step:5:110
+        - '#Doing instanceof PHPStan\\Type\\.+ is error\-prone and deprecated#'
+
+        # phpstan instanceof
+        -
+            identifier: phpstanApi.instanceofAssumption
+
+        -
+            identifier: phpstanApi.varTagAssumption
+
+        -
+            identifier: argument.type
+
+        - '#Asking about instanceof PHPStan\\.* is not covered by backward compatibility promise#'

rules-tests/DowngradePhp73/Rector/String_/DowngradeFlexibleHeredocSyntaxRector/Fixture/fixture.php.inc

@@ -42,13 +42,11 @@ SQL;
 SELECT *
 FROM `table`
 WHERE `column` = true;
-SQL
-);
+SQL);
         $this->setOnClick(<<<JAVASCRIPT
 document.getElementById('{$this->getHtmlId()}').value = '';
 document.getElementById('{$this->getHtmlId()}').onchange();
-JAVASCRIPT
-);
+JAVASCRIPT);
     }
 }
 

rules-tests/DowngradePhp73/Rector/String_/DowngradeFlexibleHeredocSyntaxRector/Fixture/line_ends_with_newline_or_semicolon.php.inc

@@ -46,13 +46,11 @@ EOS
 
         $needsDowngrade1 = sprintf(<<<EOS
 test %s
-EOS
-, 'more');
+EOS, 'more');
 
         $needsDowngrade2 = <<<EOS
 test
-EOS
-; $z = '';
+EOS; $z = '';
     }
 }
 

rules-tests/DowngradePhp74/Rector/ArrowFunction/ArrowFunctionToAnonymousFunctionRector/Fixture/arrow_function_inside_call_like.php.inc

@@ -33,8 +33,8 @@ class ErrorsConsoleStyle
 
     public function table(int $terminalWidth, int $maxHeaderWidth): void
     {
-        $f = static function ($rows) use ($terminalWidth, $maxHeaderWidth) : array {
-            return array_map(static function ($row) use ($terminalWidth, $maxHeaderWidth) : array {
+        $f = static function ($rows) use ($terminalWidth, $maxHeaderWidth): array {
+            return array_map(static function ($row) use ($terminalWidth, $maxHeaderWidth): array {
                 return array_map(static function ($s) use ($terminalWidth, $maxHeaderWidth) {
                     if ($terminalWidth > $maxHeaderWidth + 5) {
                         return wordwrap(

rules-tests/DowngradePhp74/Rector/ArrowFunction/ArrowFunctionToAnonymousFunctionRector/Fixture/preserve-by-ref-closureuse.php.inc

@@ -37,7 +37,7 @@ class PreserveByRefClosureUse
         $nameScopeMap = [];
         $f = function () use ($j, &$nameScopeMap): ?int {
             $nameScopeMap[] = function () use ($j): callable {
-                return static function (int $i) use ($j) : int {
+                return static function (int $i) use ($j): int {
                     return $i + $j;
                 };
             };

rules-tests/DowngradePhp74/Rector/ArrowFunction/ArrowFunctionToAnonymousFunctionRector/Fixture/with_nullable_return_type.php.inc

@@ -20,7 +20,7 @@ class WithNullableReturnType
 {
     public function run()
     {
-        $callable = function () : ?string {
+        $callable = function (): ?string {
             return 'Hello world';
         };
     }

rules-tests/DowngradePhp74/Rector/ArrowFunction/ArrowFunctionToAnonymousFunctionRector/Fixture/with_return_type.php.inc

@@ -20,7 +20,7 @@ class WithReturnType
 {
     public function run()
     {
-        $callable = function () : string {
+        $callable = function (): string {
             return 'Hello world';
         };
     }

rules-tests/DowngradePhp80/Rector/Expression/DowngradeMatchToSwitchRector/Fixture/in_arrow_function.php.inc

@@ -36,7 +36,7 @@ final class InArrowFunction
         ];
 
         $mapped = array_map(
-            static function (mixed $default) : mixed {
+            static function (mixed $default): mixed {
                 switch (true) {
                     case is_string($default):
                         return sprintf('"%s"', $default);

rules-tests/DowngradePhp80/Rector/Expression/DowngradeMatchToSwitchRector/Fixture/in_arrow_function2.php.inc

@@ -23,7 +23,7 @@ final class InArrowFunction2
 {
     public function run($value)
     {
-        $mapped = static function (mixed $default) : mixed {
+        $mapped = static function (mixed $default): mixed {
             switch (true) {
                 case is_string($default):
                     return sprintf('"%s"', $default);