Avoid reprint whole ClassMethod on DowngradeReadonlyPropertyRector (#325)

* Avoid reprint on DowngradeReadonlyPropertyRector

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <[email protected]>

Author: samsonasik

rules/DowngradePhp81/Rector/Property/DowngradeReadonlyPropertyRector.php

@@ -12,7 +12,6 @@
 use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocTagNode;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\Comments\NodeDocBlock\DocBlockUpdater;
-use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\Privatization\NodeManipulator\VisibilityManipulator;
 use Rector\Rector\AbstractRector;
 use Rector\ValueObject\MethodName;
@@ -102,17 +101,13 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        $hasChangedDoc = false;
         $hasChanged = false;
         foreach ($node->params as $param) {
             if (! $this->visibilityManipulator->isReadonly($param)) {
                 continue;
             }
 
-            if ($this->addPhpDocTag($param)) {
-                $hasChangedDoc = true;
-            }
-
+            $this->addPhpDocTag($param);
             $this->visibilityManipulator->removeReadonly($param);
             $hasChanged = true;
         }
@@ -121,23 +116,18 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        if ($hasChangedDoc) {
-            $node->setAttribute(AttributeKey::ORIGINAL_NODE, null);
-        }
-
         return $node;
     }
 
-    private function addPhpDocTag(Property|Param $node): bool
+    private function addPhpDocTag(Property|Param $node): void
     {
         $phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($node);
 
         if ($phpDocInfo->hasByName(self::TAGNAME)) {
-            return false;
+            return;
         }
 
         $phpDocInfo->addPhpDocTagNode(new PhpDocTagNode('@' . self::TAGNAME, new GenericTagValueNode('')));
         $this->docBlockUpdater->updateRefactoredNodeWithPhpDocInfo($node);
-        return true;
     }
 }

rules/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector.php

@@ -110,16 +110,15 @@ public function refactor(Node $node): ?ClassMethod
         return null;
     }
 
-    private function addPhpDocTag(Property|Param $node): bool
+    private function addPhpDocTag(Property|Param $node): void
     {
         $phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($node);
 
         if ($phpDocInfo->hasByName(self::TAGNAME)) {
-            return false;
+            return;
         }
 
         $phpDocInfo->addPhpDocTagNode(new PhpDocTagNode('@' . self::TAGNAME, new GenericTagValueNode('')));
         $this->docBlockUpdater->updateRefactoredNodeWithPhpDocInfo($node);
-        return true;
     }
 }

tests/Issues/DowngradeReadonlyClassPropertyToPhp80/Fixture/fixture.php.inc

@@ -17,12 +17,10 @@ namespace Rector\Tests\Issues\DowngradeReadonlyClassPropertyToPhp80\Fixture;
 
 final class Fixture
 {
-    public function __construct(
-        /**
-         * @readonly
-         */
-        public array $property
-    )
+    public function __construct(/**
+     * @readonly
+     */
+    public array $property)
     {
     }
 }