[DowngradePhp74] Handle merge const on DowngradeArraySpreadStringKeyRector + DowngradeArraySpreadRector

Author: samsonasik

tests/Issues/IssueDowngradeArraySpread/Fixture/merge_const.php.inc

@@ -0,0 +1,103 @@
+<?php
+
+namespace Rector\Tests\Issues\IssueDowngradeArraySpread\Fixture;
+
+use PhpCsFixer\Tokenizer\CT;
+use PhpCsFixer\Tokenizer\FCT;
+
+class MergeConst
+{
+    private const PROPERTY_TYPE_DECLARATION_KINDS = [
+        \T_STRING,
+        \T_NS_SEPARATOR,
+        CT::T_NULLABLE_TYPE,
+        CT::T_ARRAY_TYPEHINT,
+        CT::T_TYPE_ALTERNATION,
+        CT::T_TYPE_INTERSECTION,
+        CT::T_DISJUNCTIVE_NORMAL_FORM_TYPE_PARENTHESIS_OPEN,
+        CT::T_DISJUNCTIVE_NORMAL_FORM_TYPE_PARENTHESIS_CLOSE
+    ];
+
+    private const EXPECTED_KINDS_GENERIC = [
+        \T_ABSTRACT,
+        \T_FINAL, \T_PRIVATE,
+        \T_PROTECTED, \T_PUBLIC,
+        \T_STATIC,
+        \T_VAR,
+        CT::T_CONSTRUCTOR_PROPERTY_PROMOTION_PUBLIC,
+        CT::T_CONSTRUCTOR_PROPERTY_PROMOTION_PROTECTED,
+        CT::T_CONSTRUCTOR_PROPERTY_PROMOTION_PRIVATE,
+        FCT::T_READONLY,
+        FCT::T_PRIVATE_SET,
+        FCT::T_PROTECTED_SET,
+        FCT::T_PUBLIC_SET
+    ];
+
+    private const EXPECTED_KINDS_PROPERTY_KINDS = [
+        ...self::EXPECTED_KINDS_GENERIC,
+        ...self::PROPERTY_TYPE_DECLARATION_KINDS
+    ];
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Issues\IssueDowngradeArraySpread\Fixture;
+
+use PhpCsFixer\Tokenizer\CT;
+use PhpCsFixer\Tokenizer\FCT;
+
+class MergeConst
+{
+    private const PROPERTY_TYPE_DECLARATION_KINDS = [
+        \T_STRING,
+        \T_NS_SEPARATOR,
+        CT::T_NULLABLE_TYPE,
+        CT::T_ARRAY_TYPEHINT,
+        CT::T_TYPE_ALTERNATION,
+        CT::T_TYPE_INTERSECTION,
+        CT::T_DISJUNCTIVE_NORMAL_FORM_TYPE_PARENTHESIS_OPEN,
+        CT::T_DISJUNCTIVE_NORMAL_FORM_TYPE_PARENTHESIS_CLOSE
+    ];
+
+    private const EXPECTED_KINDS_GENERIC = [
+        \T_ABSTRACT,
+        \T_FINAL, \T_PRIVATE,
+        \T_PROTECTED, \T_PUBLIC,
+        \T_STATIC,
+        \T_VAR,
+        CT::T_CONSTRUCTOR_PROPERTY_PROMOTION_PUBLIC,
+        CT::T_CONSTRUCTOR_PROPERTY_PROMOTION_PROTECTED,
+        CT::T_CONSTRUCTOR_PROPERTY_PROMOTION_PRIVATE,
+        FCT::T_READONLY,
+        FCT::T_PRIVATE_SET,
+        FCT::T_PROTECTED_SET,
+        FCT::T_PUBLIC_SET
+    ];
+
+    private const EXPECTED_KINDS_PROPERTY_KINDS = [
+        \T_ABSTRACT,
+        \T_FINAL, \T_PRIVATE,
+        \T_PROTECTED, \T_PUBLIC,
+        \T_STATIC,
+        \T_VAR,
+        CT::T_CONSTRUCTOR_PROPERTY_PROMOTION_PUBLIC,
+        CT::T_CONSTRUCTOR_PROPERTY_PROMOTION_PROTECTED,
+        CT::T_CONSTRUCTOR_PROPERTY_PROMOTION_PRIVATE,
+        FCT::T_READONLY,
+        FCT::T_PRIVATE_SET,
+        FCT::T_PROTECTED_SET,
+        FCT::T_PUBLIC_SET,
+        \T_STRING,
+        \T_NS_SEPARATOR,
+        CT::T_NULLABLE_TYPE,
+        CT::T_ARRAY_TYPEHINT,
+        CT::T_TYPE_ALTERNATION,
+        CT::T_TYPE_INTERSECTION,
+        CT::T_DISJUNCTIVE_NORMAL_FORM_TYPE_PARENTHESIS_OPEN,
+        CT::T_DISJUNCTIVE_NORMAL_FORM_TYPE_PARENTHESIS_CLOSE
+    ];
+}
+
+?>