Re-ensure nullable type on constructor when param has type (#246)

* Re-ensure nullable type on constructor when param has type

* fix

Author: samsonasik

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/Fixture/param_no_type.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+final class ParamNoType
+{
+    public function __construct(public $o1 = new stdClass)
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector\Fixture;
+
+final class ParamNoType
+{
+    public function __construct(public $o1 = null)
+    {
+        $this->o1 = $o1 ?? new stdClass;
+    }
+}
+
+?>

rules/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector.php

@@ -176,7 +176,7 @@ private function replaceNewInParams(ClassMethod|Closure|Function_ $functionLike)
             }
 
             // recheck after
-            if ($isConstructor) {
+            if ($isConstructor && $param->type !== null) {
                 $param->type = $this->ensureNullableType($param->type);
             }