Static fixes (#349)

* cs

* static fixes

* remove node visitor stop from DowngradeHashAlgorithmXxHashRector

Author: TomasVotruba

composer.json

@@ -13,6 +13,8 @@
         "phpunit/phpunit": "^11.5",
         "rector/rector-src": "dev-main",
         "symplify/easy-coding-standard": "^12.3",
+        "symplify/phpstan-extensions": "^12.0",
+        "symplify/phpstan-rules": "^14.9",
         "symplify/rule-doc-generator": "^12.2",
         "symplify/vendor-patches": "^11.5",
         "tomasvotruba/class-leak": "^1.0",

phpstan.neon

@@ -1,10 +1,10 @@
-# to be enabled later once rector upgraded to use phpstan v2
-# includes:
-#    - vendor/symplify/phpstan-rules/config/symplify-rules.neon
-#    - vendor/symplify/phpstan-rules/config/rector-rules.neon
+includes:
+    - vendor/symplify/phpstan-rules/config/symplify-rules.neon
+    - vendor/symplify/phpstan-rules/config/rector-rules.neon
 
 parameters:
     level: 8
+    errorFormat: symplify
 
     reportUnmatchedIgnoredErrors: false
 
@@ -57,16 +57,16 @@ parameters:
         - '#Doing instanceof PHPStan\\Type\\.+ is error\-prone and deprecated#'
 
         # phpstan instanceof
-        -
-            identifier: phpstanApi.instanceofAssumption
-
-        -
-            identifier: phpstanApi.varTagAssumption
+        - identifier: phpstanApi.instanceofAssumption
+        - identifier: phpstanApi.varTagAssumption
+        - '#Asking about instanceof PHPStan\\.* is not covered by backward compatibility promise#'
 
         -
             identifier: argument.type
-
-        - '#Asking about instanceof PHPStan\\.* is not covered by backward compatibility promise#'
+            paths:
+                - rules/DowngradePhp85/Rector/StmtsAwareInterface/DowngradePipeOperatorRector.php
+                - rules/DowngradePhp85/Rector/Class_/DowngradeFinalPropertyPromotionRector.php
+                -  rules/DowngradePhp80/Rector/New_/DowngradeArbitraryExpressionsSupportRector.php
 
         # false positive intanceof in OR usage
         -
@@ -76,3 +76,30 @@ parameters:
         -
             identifier: deadCode.unreachable
             path: rules/DowngradePhp80/Rector/NullsafeMethodCall/DowngradeNullsafeToTernaryOperatorRector.php
+
+        # cached printed nodes
+        -
+            identifier: rector.noPropertyNodeAssign
+            paths:
+                - rules/DowngradePhp83/Rector/FuncCall/DowngradeJsonValidateRector.php
+                - rules/DowngradePhp81/Rector/FuncCall/DowngradeArrayIsListRector.php
+                - rules/DowngradePhp72/Rector/FuncCall/DowngradeStreamIsattyRector.php
+
+        # already registered in PHP 8.1 set
+        -
+            identifier: rector.upgradeDowngradeRegisteredInSet
+            path: rules/DowngradePhp74/Rector/Array_/DowngradeArraySpreadRector.php
+
+        # valid stmts property check
+        -
+            identifier: symplify.forbiddenFuncCall
+            path: rules/DowngradePhp73/Rector/FuncCall/DowngradeArrayKeyFirstLastRector.php
+
+        # false positive
+        -
+            identifier: symplify.seeAnnotationToTest
+            path:  rules/DowngradePhp85/Rector/StmtsAwareInterface/DowngradePipeOperatorRector.php
+
+        -
+            identifier: rector.noIntegerRefactorReturn
+            path:  rules/DowngradePhp82/Rector/FuncCall/DowngradeIteratorCountToArrayRector.php

rules-tests/DowngradePhp81/Rector/FuncCall/DowngradeHashAlgorithmXxHash/Fixture/fixture_constant.php.inc

@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\DowngradePhp81\Rector\FuncCall\DowngradeHashAlgorithmXxHash\Fixture;
 
-class Fixture
+final class FixtureConstant
 {
     public function run()
     {
@@ -16,7 +16,7 @@ class Fixture
 
 namespace Rector\Tests\DowngradePhp81\Rector\FuncCall\DowngradeHashAlgorithmXxHash\Fixture;
 
-class Fixture
+final class FixtureConstant
 {
     public function run()
     {

rules-tests/DowngradePhp81/Rector/FuncCall/DowngradeHashAlgorithmXxHash/Fixture/fixture_named_arguments.php.inc

@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\DowngradePhp81\Rector\FuncCall\DowngradeHashAlgorithmXxHash\Fixture;
 
-class Fixture
+final class FixtureNamedArguments
 {
     public function run()
     {
@@ -16,7 +16,7 @@ class Fixture
 
 namespace Rector\Tests\DowngradePhp81\Rector\FuncCall\DowngradeHashAlgorithmXxHash\Fixture;
 
-class Fixture
+final class FixtureNamedArguments
 {
     public function run()
     {

rules-tests/DowngradePhp81/Rector/FuncCall/DowngradeHashAlgorithmXxHash/Fixture/fixture_named_arguments_false_order.php.inc

@@ -2,11 +2,15 @@
 
 namespace Rector\Tests\DowngradePhp81\Rector\FuncCall\DowngradeHashAlgorithmXxHash\Fixture;
 
-class Fixture
+final class FixtureXxh32
 {
     public function run()
     {
-        return hash('xxh32', 'some-data-to-hash');
+        $value = hash('xxh32', 'some-data-to-hash');
+
+        $value = hash('xxh64', 'some-data-to-hash');
+
+        $value = hash('xxh128', 'some-data-to-hash');
     }
 }
 
@@ -16,11 +20,15 @@ class Fixture
 
 namespace Rector\Tests\DowngradePhp81\Rector\FuncCall\DowngradeHashAlgorithmXxHash\Fixture;
 
-class Fixture
+final class FixtureXxh32
 {
     public function run()
     {
-        return hash('md5', 'some-data-to-hash');
+        $value = hash('md5', 'some-data-to-hash');
+
+        $value = hash('md5', 'some-data-to-hash');
+
+        $value = hash('md5', 'some-data-to-hash');
     }
 }
 

rules-tests/DowngradePhp81/Rector/FuncCall/DowngradeHashAlgorithmXxHash/Fixture/fixture_xxh128.php.inc

@@ -6,8 +6,12 @@ final class SkipCheckVersionCompareTernary
 {
     public function run_v()
     {
-        return version_compare(PHP_VERSION, '8.1','>=')
+        $value = version_compare(PHP_VERSION, '8.1','>=')
             ? hash( 'xxh128', $value )
             : hash( 'md4', $value );
+
+        $value = version_compare(PHP_VERSION, '8.1','<')
+            ? hash( 'md4', $value )
+            : hash( 'xxh128', $value );
     }
 }