Fix print

Author: samsonasik

rules/DowngradePhp81/Rector/Property/DowngradeReadonlyPropertyRector.php

@@ -6,13 +6,16 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Param;
+use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Property;
 use PHPStan\PhpDocParser\Ast\PhpDoc\GenericTagValueNode;
 use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocTagNode;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\Comments\NodeDocBlock\DocBlockUpdater;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\Privatization\NodeManipulator\VisibilityManipulator;
 use Rector\Rector\AbstractRector;
+use Rector\ValueObject\MethodName;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
@@ -40,7 +43,7 @@ public function __construct(
      */
     public function getNodeTypes(): array
     {
-        return [Property::class, Param::class];
+        return [Property::class, ClassMethod::class];
     }
 
     public function getRuleDefinition(): RuleDefinition
@@ -81,30 +84,60 @@ public function __construct()
     }
 
     /**
-     * @param Property|Param $node
+     * @param Property|ClassMethod $node
      */
     public function refactor(Node $node): ?Node
     {
-        if (! $this->visibilityManipulator->isReadonly($node)) {
+        if ($node instanceof Property) {
+            if (! $this->visibilityManipulator->isReadonly($node)) {
+                return null;
+            }
+
+            $this->addPhpDocTag($node);
+            $this->visibilityManipulator->removeReadonly($node);
+            return $node;
+        }
+
+        if (! $this->isName($node, MethodName::CONSTRUCT)) {
             return null;
         }
 
-        $this->addPhpDocTag($node);
+        $hasChangedDoc = false;
+        $hasChanged = false;
+        foreach ($node->params as $param) {
+            if (! $this->visibilityManipulator->isReadonly($param)) {
+                continue;
+            }
+
+            if ($this->addPhpDocTag($param)) {
+                $hasChangedDoc = true;
+            }
+
+            $this->visibilityManipulator->removeReadonly($param);
+            $hasChanged = true;
+        }
 
-        $this->visibilityManipulator->removeReadonly($node);
+        if (! $hasChanged) {
+            return null;
+        }
+
+        if ($hasChangedDoc) {
+            $node->setAttribute(AttributeKey::ORIGINAL_NODE, null);
+        }
 
         return $node;
     }
 
-    private function addPhpDocTag(Property|Param $node): void
+    private function addPhpDocTag(Property|Param $node): bool
     {
         $phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($node);
 
         if ($phpDocInfo->hasByName(self::TAGNAME)) {
-            return;
+            return false;
         }
 
         $phpDocInfo->addPhpDocTagNode(new PhpDocTagNode('@' . self::TAGNAME, new GenericTagValueNode('')));
         $this->docBlockUpdater->updateRefactoredNodeWithPhpDocInfo($node);
+        return true;
     }
 }

tests/Issues/DowngradeReadonlyClassPropertyToPhp80/Fixture/fixture.php.inc

@@ -17,7 +17,12 @@ namespace Rector\Tests\Issues\DowngradeReadonlyClassPropertyToPhp80\Fixture;
 
 final class Fixture
 {
-    public function __construct(public array $property)
+    public function __construct(
+        /**
+         * @readonly
+         */
+        public array $property
+    )
     {
     }
 }