[DowngradePhp80] Add DowngradeSubstrFalsyRector (#339)

* [DowngradePhp80] Add DowngradeSubstrFalsyRector

* [DowngradePhp80] Add DowngradeSubstrFalsyRector

* [DowngradePhp80] Add DowngradeSubstrFalsyRector

* [DowngradePhp80] Add DowngradeSubstrFalsyRector

* skip negated

* skip casted bool

* skip compared to false

* [ci-review] Rector Rectify

* skip compared to false

* skip zero offset

* skip zero offset

* skip negative offset

* skip with concat

* [ci-review] Rector Rectify

* skip allow falsy arg

* use MethodCall and StaticCall as current ReflectionResolver can get

* skip append

* skip direct on if cond

* skip direct on if cond

* skip direct on while and do cond

* add fixture for skip sprintf arg

* skip as array key

* skip as array dim fetch dim

* skip in binary op

* skip new arg falsy

* update constant

* add failing fixture zero offset, negative length

* add failing fixture zero offset, negative length

* fix

---------

Co-authored-by: GitHub Action <[email protected]>

Author: samsonasik

config/set/downgrade-php80.php

@@ -23,6 +23,7 @@
 use Rector\DowngradePhp80\Rector\FuncCall\DowngradeStrContainsRector;
 use Rector\DowngradePhp80\Rector\FuncCall\DowngradeStrEndsWithRector;
 use Rector\DowngradePhp80\Rector\FuncCall\DowngradeStrStartsWithRector;
+use Rector\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector;
 use Rector\DowngradePhp80\Rector\FunctionLike\DowngradeMixedTypeDeclarationRector;
 use Rector\DowngradePhp80\Rector\FunctionLike\DowngradeUnionTypeDeclarationRector;
 use Rector\DowngradePhp80\Rector\Instanceof_\DowngradeInstanceofStringableRector;
@@ -91,5 +92,6 @@
         RemoveReturnTypeDeclarationFromCloneRector::class,
         DowngradeEnumToConstantListClassRector::class,
         DowngradeInstanceofStringableRector::class,
+        DowngradeSubstrFalsyRector::class,
     ]);
 };

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/DowngradeSubstrFalsyRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class DowngradeSubstrFalsyRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/by_variable_string.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class ByVariableString
+{
+    public function run(string $name)
+    {
+        return substr($name, 2);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class ByVariableString
+{
+    public function run(string $name)
+    {
+        return (string) substr($name, 2);
+    }
+}
+
+?>

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/fixture.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class Fixture
+{
+    public function run()
+    {
+        return substr("a", 2);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class Fixture
+{
+    public function run()
+    {
+        return (string) substr("a", 2);
+    }
+}
+
+?>

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/skip_already_casted.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class SkipAlreadyCasted
+{
+    public function run()
+    {
+        return (string) substr("a", 2);
+    }
+}

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/skip_append.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class SkipAppend
+{
+    public function run(string $a)
+    {
+        $a .=substr('a', 2);
+
+        return $a;
+    }
+}

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/skip_as_array_dim_fetch_dim.php.inc

@@ -0,0 +1,12 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class SkipAsArrayDimFetchDim
+{
+    public function run()
+    {
+        $data[substr('a', 2)] = 'foo';
+        var_dump($data);
+    }
+}

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/skip_as_array_key.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class SkipAsArrayKey
+{
+    public function run()
+    {
+         $data = [
+            substr('a', 2) => 'foo'
+        ];
+
+        var_dump($data);
+    }
+}

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/skip_as_falsy_arg.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class SkipAsFalsyArg
+{
+    public function run()
+    {
+        return $this->execute(substr('a', 2));
+    }
+
+    private function execute(false|string $value)
+    {
+        return $value;
+    }
+}

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/skip_casted_bool.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class SkipCastedBool
+{
+    public function run(string $name)
+    {
+        return (bool) substr($name, 2);
+    }
+}