skip zero offset

samsonasik · samsonasik · commit 30b207401de6 · 2025-10-13T21:45:29.000+07:00
diff --git a/rules/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector.php b/rules/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector.php
@@ -100,7 +100,7 @@ public function refactor(Node $node): ?Node
 
         if ($offset instanceof Arg) {
             $offsetType = $this->getType($offset->value);
-            if ($offsetType instanceof ConstantIntegerType && $offsetType->getValue() === 0) {
+            if ($offsetType instanceof ConstantIntegerType && $offsetType->getValue() <= 0) {
                 return null;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ public function refactor(Node $node): ?Node`
`100`	`100`
`101`	`101`	`if ($offset instanceof Arg) {`
`102`	`102`	`$offsetType = $this->getType($offset->value);`
`103`		`- if ($offsetType instanceof ConstantIntegerType && $offsetType->getValue() === 0) {`
	`103`	`+ if ($offsetType instanceof ConstantIntegerType && $offsetType->getValue() <= 0) {`
`104`	`104`	`return null;`
`105`	`105`	`}`
`106`	`106`