Skip to content

Commit 3514072

Browse files
committed
remove beforeTraverse() from nullsafe method call; counter is not relevant as output is already ternary nesting
1 parent 5a4fd67 commit 3514072

File tree

16 files changed

+3
-78
lines changed

16 files changed

+3
-78
lines changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"phpstan/phpstan": "^2.1.32",
1212
"phpstan/phpstan-webmozart-assert": "^2.0",
1313
"phpunit/phpunit": "^11.5",
14-
"rector/rector-src": "dev-main",
14+
"rector/rector-src": "dev-tv-rector-avoid-before-traverser",
1515
"rector/type-perfect": "^2.1",
1616
"symplify/easy-coding-standard": "^12.3",
1717
"symplify/phpstan-extensions": "^12.0",

phpstan.neon

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ parameters:
99

1010
# see https://phpstan.org/writing-php-code/phpdoc-types#global-type-aliases
1111
typeAliases:
12-
StmtsAware: \PhpParser\Node\Stmt\Block | \PhpParser\Node\Expr\Closure | \PhpParser\Node\Stmt\Case_ | \PhpParser\Node\Stmt\Catch_ | \PhpParser\Node\Stmt\ClassMethod | \PhpParser\Node\Stmt\Do_ | \PhpParser\Node\Stmt\Else_ | \PhpParser\Node\Stmt\ElseIf_ | \PhpParser\Node\Stmt\Finally_ | \PhpParser\Node\Stmt\For_ | \PhpParser\Node\Stmt\Foreach_ | \PhpParser\Node\Stmt\Function_ | \PhpParser\Node\Stmt\If_ | \PhpParser\Node\Stmt\Namespace_ | \PhpParser\Node\Stmt\TryCatch | \PhpParser\Node\Stmt\While_ | \Rector\PhpParser\Node\CustomNode\FileWithoutNamespace
12+
StmtsAware: \PhpParser\Node\Stmt\Block | \PhpParser\Node\Expr\Closure | \PhpParser\Node\Stmt\Case_ | \PhpParser\Node\Stmt\Catch_ | \PhpParser\Node\Stmt\ClassMethod | \PhpParser\Node\Stmt\Do_ | \PhpParser\Node\Stmt\Else_ | \PhpParser\Node\Stmt\ElseIf_ | \PhpParser\Node\Stmt\Finally_ | \PhpParser\Node\Stmt\For_ | \PhpParser\Node\Stmt\Foreach_ | \PhpParser\Node\Stmt\Function_ | \PhpParser\Node\Stmt\If_ | \PhpParser\Node\Stmt\Namespace_ | \PhpParser\Node\Stmt\TryCatch | \PhpParser\Node\Stmt\While_ | \Rector\PhpParser\Node\FileNode
1313

1414
# requires exact closure types
1515
checkMissingCallableSignature: true
@@ -92,13 +92,3 @@ parameters:
9292
-
9393
identifier: symplify.forbiddenFuncCall
9494
path: rules/DowngradePhp73/Rector/FuncCall/DowngradeArrayKeyFirstLastRector.php
95-
96-
# false positive
97-
-
98-
identifier: symplify.seeAnnotationToTest
99-
path: rules/DowngradePhp85/Rector/StmtsAwareInterface/DowngradePipeOperatorRector.php
100-
101-
# handle next
102-
-
103-
identifier: method.parentMethodFinalByPhpDoc
104-
path: rules/DowngradePhp80/Rector/NullsafeMethodCall/DowngradeNullsafeToTernaryOperatorRector.php

rules-tests/DowngradePhp80/Rector/NullsafeMethodCall/DowngradeNullsafeToTernaryOperatorRector/Fixture/short_circuit4.php.inc

Lines changed: 0 additions & 27 deletions
This file was deleted.

rules-tests/DowngradePhp80/Rector/NullsafeMethodCall/DowngradeNullsafeToTernaryOperatorRector/Fixture/short_circuit5.php.inc

Lines changed: 0 additions & 27 deletions
This file was deleted.

rules-tests/DowngradePhp85/Rector/StmtsAwareInterface/DowngradePipeOperatorRectorTest/DowngradePipeOperatorRectorTest.php renamed to rules-tests/DowngradePhp85/Rector/StmtsAwareInterface/DowngradePipeOperatorRector/DowngradePipeOperatorRectorTest.php

File renamed without changes.

rules-tests/DowngradePhp85/Rector/StmtsAwareInterface/DowngradePipeOperatorRectorTest/Fixture/complex_pipe_chain.php.inc renamed to rules-tests/DowngradePhp85/Rector/StmtsAwareInterface/DowngradePipeOperatorRector/Fixture/complex_pipe_chain.php.inc

File renamed without changes.

rules-tests/DowngradePhp85/Rector/StmtsAwareInterface/DowngradePipeOperatorRectorTest/Fixture/multiple_pipes.php.inc renamed to rules-tests/DowngradePhp85/Rector/StmtsAwareInterface/DowngradePipeOperatorRector/Fixture/multiple_pipes.php.inc

File renamed without changes.

rules-tests/DowngradePhp85/Rector/StmtsAwareInterface/DowngradePipeOperatorRectorTest/Fixture/pipe_in_assignment.php.inc renamed to rules-tests/DowngradePhp85/Rector/StmtsAwareInterface/DowngradePipeOperatorRector/Fixture/pipe_in_assignment.php.inc

File renamed without changes.

rules-tests/DowngradePhp85/Rector/StmtsAwareInterface/DowngradePipeOperatorRectorTest/Fixture/pipe_with_closure.php.inc renamed to rules-tests/DowngradePhp85/Rector/StmtsAwareInterface/DowngradePipeOperatorRector/Fixture/pipe_with_closure.php.inc

File renamed without changes.

rules-tests/DowngradePhp85/Rector/StmtsAwareInterface/DowngradePipeOperatorRectorTest/Fixture/pipe_with_method_call.php.inc renamed to rules-tests/DowngradePhp85/Rector/StmtsAwareInterface/DowngradePipeOperatorRector/Fixture/pipe_with_method_call.php.inc

File renamed without changes.

0 commit comments

Comments
 (0)