direct assign

Author: samsonasik

rules-tests/DowngradePhp80/Rector/Expression/DowngradeThrowExprRector/Fixture/multiple_coalesce.php.inc

@@ -20,10 +20,9 @@ class MultipleCoalesce
 {
     public function run($content)
     {
-        if (($content->getInternalId() ?? $content->getId()) === null) {
+        if (($contentId = $content->getInternalId() ?? $content->getId()) === null) {
             throw new \LogicException('content id is required for ackVersion');
         }
-        $contentId = $content->getInternalId() ?? $content->getId();
     }
 }
 

rules/DowngradePhp80/Rector/Expression/DowngradeThrowExprRector.php

@@ -190,7 +190,7 @@ private function refactorCoalesce(Coalesce $coalesce, ?Assign $assign): If_|null
 
             if ($rightCoalesce instanceof Throw_) {
                 $coalesce = new Coalesce($leftCoalesce, $rightCoalesce);
-                return $this->processCoalesce($coalesce, $assign);
+                return $this->processCoalesce($coalesce, $assign, true);
             }
 
             return null;
@@ -202,7 +202,7 @@ private function refactorCoalesce(Coalesce $coalesce, ?Assign $assign): If_|null
     /**
      * @return If_|Stmt[]|null
      */
-    private function processCoalesce(Coalesce $coalesce, ?Assign $assign): If_|null|array
+    private function processCoalesce(Coalesce $coalesce, ?Assign $assign, bool $innerAssign = false): If_|null|array
     {
         if (! $this->coalesceAnalyzer->hasIssetableLeft($coalesce)) {
             return null;
@@ -219,6 +219,11 @@ private function processCoalesce(Coalesce $coalesce, ?Assign $assign): If_|null|
 
         $assign->expr = $coalesce->left;
 
+        if ($innerAssign && $if->cond instanceof Identical) {
+            $if->cond->left = new Assign($assign->var, $if->cond->left);
+            return $if;
+        }
+
         return [$if, new Expression($assign)];
     }