[DowngradePhp84] Apply on return on DowngradeArrayAllRector (#299)

* [DowngradePhp84] Apply on return on DowngradeArrayAllRector

* [DowngradePhp84] Apply on return on DowngradeArrayAllRector

* [ci-review] Rector Rectify

* ensure pass assign

---------

Co-authored-by: GitHub Action <[email protected]>

Author: samsonasik

rules-tests/DowngradePhp84/Rector/Expression/DowngradeArrayAllRector/Fixture/on_return.php.inc

@@ -0,0 +1,34 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp84\Rector\Expression\DowngradeArrayAllRector\Fixture;
+
+class OnReturn
+{
+    public function run(array $animals)
+    {
+        return array_all($animals, fn($animal) => str_starts_with($animal, 'c'));
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp84\Rector\Expression\DowngradeArrayAllRector\Fixture;
+
+class OnReturn
+{
+    public function run(array $animals)
+    {
+        $found = true;
+        foreach ($animals as $animal) {
+            if (!str_starts_with($animal, 'c')) {
+                $found = false;
+                break;
+            }
+        }
+        return $found;
+    }
+}
+
+?>

rules/DowngradePhp74/Rector/ArrowFunction/ArrowFunctionToAnonymousFunctionRector.php

@@ -12,6 +12,7 @@
 use PhpParser\Node\Expr\Closure;
 use PhpParser\Node\Expr\Throw_;
 use PhpParser\Node\Expr\Variable;
+use PhpParser\Node\Param;
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\Node\Stmt\Return_;
 use PHPStan\Analyser\Scope;
@@ -101,7 +102,7 @@ public function refactor(Node $node): Closure
                 $isAlsoParam = in_array(
                     $node->expr->expr->name,
                     array_map(
-                        static fn ($param) => $param->var instanceof Variable ? $param->var->name : null,
+                        static fn (Param $param) => $param->var instanceof Variable ? $param->var->name : null,
                         $node->params
                     )
                 );

rules/DowngradePhp84/Rector/Expression/DowngradeArrayAllRector.php

@@ -10,12 +10,16 @@
 use PhpParser\Node\Expr\BooleanNot;
 use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Name;
 use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\Break_;
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\Node\Stmt\Foreach_;
 use PhpParser\Node\Stmt\If_;
+use PhpParser\Node\Stmt\Return_;
+use Rector\Naming\Naming\VariableNaming;
+use Rector\PHPStan\ScopeFetcher;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -27,9 +31,14 @@
  */
 final class DowngradeArrayAllRector extends AbstractRector
 {
+    public function __construct(
+        private readonly VariableNaming $variableNaming
+    ) {
+    }
+
     public function getNodeTypes(): array
     {
-        return [Expression::class];
+        return [Expression::class, Return_::class];
     }
 
     public function getRuleDefinition(): RuleDefinition
@@ -57,28 +66,36 @@ public function getRuleDefinition(): RuleDefinition
     }
 
     /**
-     * @param Expression $node
+     * @param Expression|Return_ $node
      * @return Stmt[]|null
      */
     public function refactor(Node $node): ?array
     {
-        if (! $node->expr instanceof Assign) {
+        if ($node instanceof Return_ && ! $node->expr instanceof FuncCall) {
+            return null;
+        }
+
+        if ($node instanceof Expression && ! $node->expr instanceof Assign) {
             return null;
         }
 
-        if (! $node->expr->expr instanceof FuncCall) {
+        $expr = $node instanceof Expression && $node->expr instanceof Assign
+            ? $node->expr->expr
+            : $node->expr;
+
+        if (! $expr instanceof FuncCall) {
             return null;
         }
 
-        if (! $this->isName($node->expr->expr, 'array_all')) {
+        if (! $this->isName($expr, 'array_all')) {
             return null;
         }
 
-        if ($node->expr->expr->isFirstClassCallable()) {
+        if ($expr->isFirstClassCallable()) {
             return null;
         }
 
-        $args = $node->expr->expr->getArgs();
+        $args = $expr->getArgs();
         if (count($args) !== 2) {
             return null;
         }
@@ -87,17 +104,19 @@ public function refactor(Node $node): ?array
             return null;
         }
 
+        $scope = ScopeFetcher::fetch($node);
+        $variable = $node instanceof Expression && $node->expr instanceof Assign
+            ? $node->expr->var
+            : new Variable($this->variableNaming->createCountedValueName('found', $scope));
+
         $valueCond = $args[1]->value->expr;
         $if = new If_(new BooleanNot($valueCond), [
-            'stmts' => [
-                new Expression(new Assign($node->expr->var, new ConstFetch(new Name('false')))),
-                new Break_(),
-            ],
+            'stmts' => [new Expression(new Assign($variable, new ConstFetch(new Name('false')))), new Break_()],
         ]);
 
-        return [
+        $result = [
             // init
-            new Expression(new Assign($node->expr->var, new ConstFetch(new Name('true')))),
+            new Expression(new Assign($variable, new ConstFetch(new Name('true')))),
 
             // foreach loop
             new Foreach_(
@@ -113,5 +132,11 @@ public function refactor(Node $node): ?array
                     ],
             ),
         ];
+
+        if ($node instanceof Return_) {
+            $result[] = new Return_($variable);
+        }
+
+        return $result;
     }
 }