Check for variable name in parameters before adding to uses (#268)

* Check for variable name in parameters before adding to uses

* Add test for variable duplicated in parameter and use

* Resolve undefined property access error

* Fix coding style

* Fix coding style

Author: bryannielsen

rules-tests/DowngradePhp74/Rector/ArrowFunction/ArrowFunctionToAnonymousFunctionRector/Fixture/no_params_duplicated_in_use.php.inc

@@ -0,0 +1,89 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp74\Rector\ArrowFunction\ArrowFunctionToAnonymousFunctionRector\Fixture;
+
+class NoParamsDuplicatedInUse
+{
+    public function single()
+    {
+        $callable = fn($param) => $param;
+    }
+
+    public function singleArrayAssignment()
+    {
+        $callable = fn($param) => $arr[] = $param;
+    }
+
+    public function multiple()
+    {
+        $callable = fn($param, $param2) => $param + $param2;
+    }
+
+    public function multipleArrayAssignment()
+    {
+        $callable = fn($param, $param2) => $arr[] = $param + $param2;
+    }
+
+    public function mixed()
+    {
+        $callable = fn($param) => $param + $param2;
+    }
+
+    public function mixedArrayAssignment()
+    {
+        $callable = fn($param) => $arr[] = $param + $param2;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp74\Rector\ArrowFunction\ArrowFunctionToAnonymousFunctionRector\Fixture;
+
+class NoParamsDuplicatedInUse
+{
+    public function single()
+    {
+        $callable = function ($param) {
+            return $param;
+        };
+    }
+
+    public function singleArrayAssignment()
+    {
+        $callable = function ($param) use ($arr) {
+            return $arr[] = $param;
+        };
+    }
+
+    public function multiple()
+    {
+        $callable = function ($param, $param2) {
+            return $param + $param2;
+        };
+    }
+
+    public function multipleArrayAssignment()
+    {
+        $callable = function ($param, $param2) use ($arr) {
+            return $arr[] = $param + $param2;
+        };
+    }
+
+    public function mixed()
+    {
+        $callable = function ($param) use ($param2) {
+            return $param + $param2;
+        };
+    }
+
+    public function mixedArrayAssignment()
+    {
+        $callable = function ($param) use ($arr, $param2) {
+            return $arr[] = $param + $param2;
+        };
+    }
+}
+
+?>

rules/DowngradePhp74/Rector/ArrowFunction/ArrowFunctionToAnonymousFunctionRector.php

@@ -98,7 +98,17 @@ public function refactor(Node $node): Closure
             );
 
             if (! $isFound) {
-                $anonymousFunctionFactory->uses[] = new ClosureUse($node->expr->expr);
+                $isAlsoParam = in_array(
+                    $node->expr->expr->name,
+                    array_map(
+                        static fn ($param) => $param->var instanceof Variable ? $param->var->name : null,
+                        $node->params
+                    )
+                );
+
+                if (! $isAlsoParam) {
+                    $anonymousFunctionFactory->uses[] = new ClosureUse($node->expr->expr);
+                }
             }
         }