Add support for unknown types in DowngradeNamedArgumentRector (#289)

* add fixture

* remove unclear type named args

Author: TomasVotruba

rules-tests/DowngradePhp80/Rector/MethodCall/DowngradeNamedArgumentRector/Fixture/remove_from_unknown_type.php.inc

@@ -0,0 +1,25 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\MethodCall\DowngradeNamedArgumentRector\Fixture;
+
+final class RemoveFromUnknownType
+{
+    function someMethod($container, $abstract, $parameters ) {
+        return $container->resolve($abstract, $parameters, raiseEvents: \true);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\MethodCall\DowngradeNamedArgumentRector\Fixture;
+
+final class RemoveFromUnknownType
+{
+    function someMethod($container, $abstract, $parameters ) {
+        return $container->resolve($abstract, $parameters, \true);
+    }
+}
+
+?>

rules/DowngradePhp80/Rector/MethodCall/DowngradeNamedArgumentRector.php

@@ -12,6 +12,7 @@
 use PhpParser\Node\Expr\StaticCall;
 use PHPStan\Reflection\FunctionReflection;
 use PHPStan\Reflection\MethodReflection;
+use PHPStan\Type\MixedType;
 use Rector\DowngradePhp80\NodeAnalyzer\UnnamedArgumentResolver;
 use Rector\NodeAnalyzer\ArgsAnalyzer;
 use Rector\Rector\AbstractRector;
@@ -83,7 +84,7 @@ private function execute($a = null, $b = null)
     public function refactor(Node $node): ?Node
     {
         $args = $node->getArgs();
-        if ($this->shouldSkip($args)) {
+        if (! $this->argsAnalyzer->hasNamedArg($args)) {
             return null;
         }
 
@@ -102,19 +103,26 @@ private function removeNamedArguments(MethodCall | StaticCall | New_ | FuncCall
         }
 
         if (! $functionLikeReflection instanceof MethodReflection && ! $functionLikeReflection instanceof FunctionReflection) {
+            // remove leftovers in case of unknown type, to avoid crashing on unknown syntax
+            if ($node instanceof MethodCall) {
+                $callerType = $this->getType($node->var);
+
+                if ($callerType instanceof MixedType) {
+                    foreach ($node->getArgs() as $arg) {
+                        if ($arg->name instanceof Node) {
+                            $arg->name = null;
+                        }
+                    }
+
+                    return $node;
+                }
+            }
+
             return null;
         }
 
         $node->args = $this->unnamedArgumentResolver->resolveFromReflection($functionLikeReflection, $args);
 
         return $node;
     }
-
-    /**
-     * @param mixed[]|Arg[] $args
-     */
-    private function shouldSkip(array $args): bool
-    {
-        return ! $this->argsAnalyzer->hasNamedArg($args);
-    }
 }