skip direct on if cond

Author: samsonasik

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/compared_to_empty_string.php.inc

@@ -0,0 +1,47 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class ComparedToEmptyString
+{
+    public function run(string $name)
+    {
+        return substr($name, 2) === '';
+    }
+    
+    public function run2(string $name)
+    {
+        return substr($name, 2) !== '';
+    }
+    
+    public function run3(string $name)
+    {
+        return substr($name, 2) == '';
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class ComparedToEmptyString
+{
+    public function run(string $name)
+    {
+        return (string) substr($name, 2) === '';
+    }
+    
+    public function run2(string $name)
+    {
+        return (string) substr($name, 2) !== '';
+    }
+    
+    public function run3(string $name)
+    {
+        return (string) substr($name, 2) == '';
+    }
+}
+
+?>

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/skip_direct_cond.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class SkipDirectCond
+{
+    public function run(string $name)
+    {
+        if (substr($name, 2)) {
+            return true;
+        }
+    }
+}

rules/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector.php

@@ -19,6 +19,7 @@
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Expr\Ternary;
+use PhpParser\Node\Stmt\If_;
 use PHPStan\Reflection\FunctionReflection;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Type\Constant\ConstantIntegerType;
@@ -71,12 +72,13 @@ public function getNodeTypes(): array
             MethodCall::class,
             StaticCall::class,
             AssignOp::class,
+            If_::class,
             FuncCall::class,
         ];
     }
 
     /**
-     * @param Cast|Empty_|BooleanNot|Ternary|Identical|Concat|MethodCall|StaticCall|AssignOp|FuncCall $node
+     * @param Cast|Empty_|BooleanNot|Ternary|Identical|Concat|MethodCall|StaticCall|AssignOp|If_|FuncCall $node
      */
     public function refactor(Node $node): ?Node
     {
@@ -111,6 +113,11 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        if ($node instanceof If_) {
+            $node->cond->setAttribute(self::IS_UNCASTABLE, true);
+            return null;
+        }
+
         if ($node instanceof CallLike) {
             if ($node->isFirstClassCallable()) {
                 return null;