[Downgrade][Php81][Php80] Handle nullable downgrade initialization on use DowngradeNewInInitializerRector+DowngradePropertyPromotionRector (#243)

* [Downgrade][Php81][Php80] Handle nullable downgrade initialization on use DowngradeNewInInitializerRector+DowngradePropertyPromotionRector

* [ci-review] Rector Rectify

* fix

* fix

---------

Co-authored-by: GitHub Action <[email protected]>

Author: samsonasik

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/Fixture/new_not_promoted.php.inc

@@ -22,9 +22,9 @@ final class NewNotPromoted
 {
     public stdClass $obj;
 
-    public function __construct(stdClass $obj = null)
+    public function __construct(?stdClass $obj = null)
     {
-        $obj ??= new stdClass;
+        $this->obj = $obj ?? new stdClass;
         $this->obj = $obj;
     }
 }

rules/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector.php

@@ -162,8 +162,7 @@ private function replaceNewInParams(ClassMethod|Closure|Function_ $functionLike)
             /** @var Variable $paramVar */
             $paramVar = $param->var;
 
-            // check for property promotion
-            if ($isConstructor && $param->flags > 0) {
+            if ($isConstructor) {
                 $propertyFetch = new PropertyFetch(new Variable('this'), $paramVar->name);
                 $coalesce = new Coalesce($param->var, $default);
                 $assign = new Assign($propertyFetch, $coalesce);

tests/Issues/DowngradeNewInArrayInitializerPromotion/Fixture/new_in_array.php.inc

@@ -33,9 +33,9 @@ class NewInArray
     /**
      * @param array<string, object> $property
      */
-    public function __construct(array $property = null)
+    public function __construct(?array $property = null)
     {
-        $property ??= [
+        $this->property = $property ?? [
             'a' => new stdClass()
         ];
         $this->property = $property;

tests/Issues/DowngradeNullableInitialization/DowngradeNullableInitializationTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Issues\DowngradeNullableInitialization;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class DowngradeNullableInitializationTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

tests/Issues/DowngradeNullableInitialization/Fixture/add_nullable_initialization.php.inc

@@ -0,0 +1,32 @@
+<?php
+
+namespace Rector\Tests\Issues\DowngradeNullableInitialization\Fixture;
+
+final class AddNullableInitializtion
+{
+    public function __construct(
+        private array $doctrineTypeToScalarType = [
+            'tinyint' => new \PHPStan\Type\BooleanType(),
+        ]
+     ) {}
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Issues\DowngradeNullableInitialization\Fixture;
+
+final class AddNullableInitializtion
+{
+    private array $doctrineTypeToScalarType;
+    public function __construct(?array $doctrineTypeToScalarType = null)
+    {
+        $this->doctrineTypeToScalarType = $doctrineTypeToScalarType ?? [
+            'tinyint' => new \PHPStan\Type\BooleanType(),
+        ];
+        $this->doctrineTypeToScalarType = $doctrineTypeToScalarType;
+    }
+}
+
+?>

tests/Issues/DowngradeNullableInitialization/config/configured_rule.php

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\DowngradePhp80\Rector\Class_\DowngradePropertyPromotionRector;
+use Rector\DowngradePhp81\Rector\FunctionLike\DowngradeNewInInitializerRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rules([DowngradeNewInInitializerRector::class, DowngradePropertyPromotionRector::class]);
+};