[PHP 8.1] Add DowngradeOctalNumberRector (#187)

Author: TomasVotruba

.gitattributes

@@ -7,5 +7,4 @@ phpstan.neon export-ignore
 phpunit.xml export-ignore
 tests export-ignore
 rules-tests export-ignore
-/easy-ci.php export-ignore
 /rector.php export-ignore

config/set/downgrade-php81.php

@@ -1,8 +1,9 @@
 <?php
 
 declare(strict_types=1);
-use Rector\DowngradePhp81\Rector\MethodCall\DowngradeIsEnumRector;
 
+use Rector\DowngradePhp81\Rector\LNumber\DowngradeOctalNumberRector;
+use Rector\DowngradePhp81\Rector\MethodCall\DowngradeIsEnumRector;
 use Rector\Config\RectorConfig;
 use Rector\Core\ValueObject\PhpVersion;
 use Rector\DowngradePhp81\Rector\Array_\DowngradeArraySpreadStringKeyRector;
@@ -34,6 +35,7 @@
         DowngradeArrayIsListRector::class,
         DowngradeSetAccessibleReflectionPropertyRector::class,
         DowngradeIsEnumRector::class,
+        DowngradeOctalNumberRector::class
     ]);
 
     // @see https://php.watch/versions/8.1/internal-method-return-types#reflection

docs/rector_rules_overview.md

@@ -1,4 +1,4 @@
-# 70 Rules Overview
+# 71 Rules Overview
 
 ## ArrowFunctionToAnonymousFunctionRector
 
@@ -429,7 +429,7 @@ Downgrades `isEnum()` on class reflection
      public function run(ReflectionClass $reflectionClass)
      {
 -        return $reflectionClass->isEnum();
-+        return false;
++        return method_exists($reflectionClass, 'isEnum') ? $reflectionClass->isEnum() : false;
      }
  }
 ```
@@ -736,6 +736,25 @@ Remove the "object" param and return type, add a `@param` and `@return` tags ins
 
 <br>
 
+## DowngradeOctalNumberRector
+
+Downgrades octal numbers to decimal ones
+
+- class: [`Rector\DowngradePhp81\Rector\LNumber\DowngradeOctalNumberRector`](../rules/DowngradePhp81/Rector/LNumber/DowngradeOctalNumberRector.php)
+
+```diff
+ class SomeClass
+ {
+     public function run()
+     {
+-        return 0o777;
++        return 0777;
+     }
+ }
+```
+
+<br>
+
 ## DowngradeParameterTypeWideningRector
 
 Change param type to match the lowest type in whole family tree

easy-ci.php

@@ -18,7 +18,6 @@
         __DIR__ . '/tests',
         __DIR__ . '/rules-tests',
         __DIR__ . '/ecs.php',
-        __DIR__ . '/easy-ci.php',
     ]);
 
     $ecsConfig->ruleWithConfiguration(NoSuperfluousPhpdocTagsFixer::class, [

ecs.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DowngradePhp81\Rector\LNumber\DowngradeOctalNumberRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class DowngradeOctalNumberRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/DowngradePhp81/Rector/LNumber/DowngradeOctalNumberRector/DowngradeOctalNumberRectorTest.php

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\LNumber\DowngradeOctalNumberRector\Fixture;
+
+final class BiggerOu
+{
+    public function run()
+    {
+        return 0O777;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\LNumber\DowngradeOctalNumberRector\Fixture;
+
+final class BiggerOu
+{
+    public function run()
+    {
+        return 0777;
+    }
+}
+
+?>

rules-tests/DowngradePhp81/Rector/LNumber/DowngradeOctalNumberRector/Fixture/bigger_ou.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\LNumber\DowngradeOctalNumberRector\Fixture;
+
+final class SkipAnotherValues
+{
+    public function run()
+    {
+        $result = '0O777';
+
+        $next = '0o77Oo7';
+
+        $binaryNumber = 0b1111;
+    }
+}
+

rules-tests/DowngradePhp81/Rector/LNumber/DowngradeOctalNumberRector/Fixture/skip_another_values.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\LNumber\DowngradeOctalNumberRector\Fixture;
+
+class SomeClass
+{
+    public function run()
+    {
+        return 0o777;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp81\Rector\LNumber\DowngradeOctalNumberRector\Fixture;
+
+class SomeClass
+{
+    public function run()
+    {
+        return 0777;
+    }
+}
+
+?>

rules-tests/DowngradePhp81/Rector/LNumber/DowngradeOctalNumberRector/Fixture/some_class.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+
+use Rector\DowngradePhp81\Rector\LNumber\DowngradeOctalNumberRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(DowngradeOctalNumberRector::class);
+};