[DowngradePhp84] Add DowngradeArrayAllRector

Author: samsonasik

rector.php

@@ -12,12 +12,12 @@
     ->withPhpSets(php82: true)
     ->withSets([PHPUnitSetList::PHPUNIT_100, PHPUnitSetList::PHPUNIT_CODE_QUALITY])
     ->withPreparedSets(
+        deadCode: true,
         codeQuality: true,
         codingStyle: true,
-        deadCode: true,
+        typeDeclarations: true,
         privatization: true,
         naming: true,
-        typeDeclarations: true,
         earlyReturn: true,
         rectorPreset: true
     )->withPaths([

rules/DowngradePhp84/Rector/Expression/DowngradeArrayAllRector.php

@@ -7,14 +7,10 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr\ArrowFunction;
 use PhpParser\Node\Expr\Assign;
-use PhpParser\Node\Expr\ClassConstFetch;
-use PhpParser\Node\Expr\Closure;
 use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Expr\FuncCall;
-use PhpParser\Node\Expr\MethodCall;
-use PhpParser\Node\Identifier;
 use PhpParser\Node\Name;
-use PhpParser\Node\Name\FullyQualified;
+use PhpParser\Node\Stmt\Break_;
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\Node\Stmt\Foreach_;
 use PhpParser\Node\Stmt\If_;
@@ -90,20 +86,14 @@ public function refactor(Node $node): ?array
 
         $if = new If_($args[1]->value->expr, [
             'stmts' => [
-                new Expression(new Assign(
-                    $node->expr->var,
-                    new ConstFetch(new Name('false'))
-                )),
-                new Node\Stmt\Break_(),
+                new Expression(new Assign($node->expr->var, new ConstFetch(new Name('false')))),
+                new Break_(),
             ],
         ]);
 
         return [
             // init
-            new Expression(new Assign(
-                $node->expr->var,
-                new ConstFetch(new Name('true'))
-            )),
+            new Expression(new Assign($node->expr->var, new ConstFetch(new Name('true')))),
 
             // foreach loop
             new Foreach_(
@@ -112,10 +102,12 @@ public function refactor(Node $node): ?array
                 isset($args[1]->value->params[1]->var)
                     ? [
                         'keyVar' => $args[1]->value->params[1]->var,
-                        'stmts' => [$if]
+                        'stmts' => [$if],
                     ]
-                    : ['stmts' => [$if]],
-            )
+                    : [
+                        'stmts' => [$if],
+                    ],
+            ),
         ];
     }
 }