Re-ensure nullable type on constructor when param has type

samsonasik · samsonasik · commit 75abe79cf87c · 2024-11-23T00:40:24.000+07:00
diff --git a/rules/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector.php b/rules/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector.php
@@ -176,7 +176,7 @@ private function replaceNewInParams(ClassMethod|Closure|Function_ $functionLike)
             }
 
             // recheck after
-            if ($isConstructor) {
+            if ($isConstructor && $param->type !== null) {
                 $param->type = $this->ensureNullableType($param->type);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ private function replaceNewInParams(ClassMethod\|Closure\|Function_ $functionLike)`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`// recheck after`
`179`		`- if ($isConstructor) {`
	`179`	`+ if ($isConstructor && $param->type !== null) {`
`180`	`180`	`$param->type = $this->ensureNullableType($param->type);`
`181`	`181`	`}`
`182`	`182`