[DowngradePhp84] Allow named arg on DowngradeRoundingModeEnumRector (#335)

Author: samsonasik

rules-tests/DowngradePhp84/Rector/FuncCall/DowngradeRoundingModeEnumRector/Fixture/with_named_arg.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\Php84\Rector\FuncCall\RoundingModeEnumRector;
+
+round(precision: 0, mode: \RoundingMode::HalfAwayFromZero, value: 1.5);
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php84\Rector\FuncCall\RoundingModeEnumRector;
+
+round(precision: 0, mode: \PHP_ROUND_HALF_UP, value: 1.5);
+
+?>

rules/DowngradePhp84/Rector/FuncCall/DowngradeRoundingModeEnumRector.php

@@ -5,6 +5,7 @@
 namespace Rector\DowngradePhp84\Rector\FuncCall;
 
 use PhpParser\Node;
+use PhpParser\Node\Arg;
 use PhpParser\Node\Expr\ClassConstFetch;
 use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Expr\FuncCall;
@@ -58,17 +59,12 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        $args = $node->getArgs();
-
-        if (count($args) !== 3) {
-            return null;
-        }
-
-        if (! isset($args[2])) {
+        $arg = $node->getArg('mode', 2);
+        if (! $arg instanceof Arg) {
             return null;
         }
 
-        $modeArg = $args[2]->value;
+        $modeArg = $arg->value;
         $hasChanged = false;
         if ($modeArg instanceof ClassConstFetch && $modeArg->class instanceof FullyQualified && $this->isName(
             $modeArg->class,
@@ -89,7 +85,7 @@ public function refactor(Node $node): ?Node
                 return null;
             }
 
-            $args[2]->value = new ConstFetch(new FullyQualified($constantName));
+            $arg->value = new ConstFetch(new FullyQualified($constantName));
             $hasChanged = true;
         }