fix

Author: samsonasik

rules-tests/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector/Fixture/new_not_promoted.php.inc

@@ -22,9 +22,9 @@ final class NewNotPromoted
 {
     public stdClass $obj;
 
-    public function __construct(stdClass $obj = null)
+    public function __construct(?stdClass $obj = null)
     {
-        $obj ??= new stdClass;
+        $this->obj = $obj ?? new stdClass;
         $this->obj = $obj;
     }
 }

rules/DowngradePhp81/Rector/FunctionLike/DowngradeNewInInitializerRector.php

@@ -163,7 +163,7 @@ private function replaceNewInParams(ClassMethod|Closure|Function_ $functionLike)
             $paramVar = $param->var;
 
             // check for property promotion
-            if ($isConstructor && $param->flags > 0) {
+            if ($isConstructor) {
                 $propertyFetch = new PropertyFetch(new Variable('this'), $paramVar->name);
                 $coalesce = new Coalesce($param->var, $default);
                 $assign = new Assign($propertyFetch, $coalesce);

tests/Issues/DowngradeNewInArrayInitializerPromotion/Fixture/new_in_array.php.inc

@@ -33,9 +33,9 @@ class NewInArray
     /**
      * @param array<string, object> $property
      */
-    public function __construct(array $property = null)
+    public function __construct(?array $property = null)
     {
-        $property ??= [
+        $this->property = $property ?? [
             'a' => new stdClass()
         ];
         $this->property = $property;

tests/Issues/DowngradeNullableInitialization/Fixture/add_nullable_initialization.php.inc

@@ -22,7 +22,7 @@ final class AddNullableInitializtion
     private array $doctrineTypeToScalarType;
     public function __construct(?array $doctrineTypeToScalarType = null)
     {
-        $doctrineTypeToScalarType ??= [
+        $this->doctrineTypeToScalarType = $doctrineTypeToScalarType ?? [
             'tinyint' => new \PHPStan\Type\BooleanType(),
         ];
         $this->doctrineTypeToScalarType = $doctrineTypeToScalarType;