misc

Author: TomasVotruba

phpstan.neon

@@ -113,3 +113,6 @@ parameters:
                  - rules/DowngradePhp74/Rector/MethodCall/DowngradeReflectionGetTypeRector.php
                  - rules/DowngradePhp80/Rector/MethodCall/DowngradeReflectionGetAttributesRector.php
                  - rules/DowngradePhp73/Rector/String_/DowngradeFlexibleHeredocSyntaxRector.php
+
+        # local attribute key
+        - '#Parameter \#2 \$attributeKey of static method Rector\\PhpParser\\NodeTraverser\\SimpleNodeTraverser\:\:decorateWithAttributeValue\(\) expects#'

rules/DowngradePhp73/Rector/ConstFetch/DowngradePhp73JsonConstRector.php

@@ -23,6 +23,7 @@
 use Rector\Enum\JsonConstant;
 use Rector\NodeAnalyzer\DefineFuncCallAnalyzer;
 use Rector\NodeTypeResolver\Node\AttributeKey;
+use Rector\PhpParser\NodeTraverser\SimpleNodeTraverser;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -42,7 +43,7 @@ final class DowngradePhp73JsonConstRector extends AbstractRector
     /**
      * @var array<string>
      */
-    private const REFACTOR_FUNCS = ['json_decode', 'json_encode'];
+    private const JSON_FUNCTIONS = ['json_decode', 'json_encode'];
 
     public function __construct(
         private readonly JsonConstCleaner $jsonConstCleaner,
@@ -63,12 +64,12 @@ public function getRuleDefinition(): RuleDefinition
 CODE_SAMPLE
                     ,
                     <<<'CODE_SAMPLE'
-$json json_encode($content, 0);
+$json = json_encode($content);
 if (json_last_error() !== JSON_ERROR_NONE) {
     throw new \Exception(json_last_error_msg());
 }
 
-$content = json_decode($json, null, 512, 0);
+$content = json_decode($json, null, 512);
 if (json_last_error() !== JSON_ERROR_NONE) {
     throw new \Exception(json_last_error_msg());
 }
@@ -115,10 +116,7 @@ private function markConstantKnownInInnerStmts(If_ $if): void
             return;
         }
 
-        $this->traverseNodesWithCallable($if, static function (Node $node): null {
-            $node->setAttribute(self::PHP73_JSON_CONSTANT_IS_KNOWN, true);
-            return null;
-        });
+        SimpleNodeTraverser::decorateWithAttributeValue($if, self::PHP73_JSON_CONSTANT_IS_KNOWN, true);
     }
 
     private function resolveFuncCall(Expression $Expression): ?FuncCall
@@ -164,7 +162,7 @@ private function refactorExpression(Expression $expression): ?array
         }
 
         // Nothing to do if not a refactored function
-        if (! in_array($this->getName($funcCall), self::REFACTOR_FUNCS, true)) {
+        if (! in_array($this->getName($funcCall), self::JSON_FUNCTIONS, true)) {
             return null;
         }