[DowngradePhp73] Handle next if with BooleanOr condition that cause possible non-array data on DowngradeArrayKeyFirstLastRector (#207)

Author: samsonasik

rules-tests/DowngradePhp73/Rector/FuncCall/DowngradeArrayKeyFirstLastRector/Fixture/possible_non_array_or_object_array_key_first.php.inc

@@ -0,0 +1,46 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp73\Rector\FuncCall\DowngradeArrayKeyFirstLastRector\Fixture;
+
+class PossibleNonArrayOrObjectArrayKeyFirst
+{
+    protected mixed $value = null;
+
+    private function run(): bool
+    {
+        $v = $this->value;
+
+        if (!\is_array($v) || 1 !== \count($v) || 10 !== \strlen($k = (string) array_key_first($v)) || "\x9D" !== $k[0] || "\0" !== $k[5] || "\x5F" !== $k[9]) {
+            return false;
+        }
+
+        return true;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp73\Rector\FuncCall\DowngradeArrayKeyFirstLastRector\Fixture;
+
+class PossibleNonArrayOrObjectArrayKeyFirst
+{
+    protected mixed $value = null;
+
+    private function run(): bool
+    {
+        $v = $this->value;
+        if (is_array($v)) {
+            reset($v);
+        }
+
+        if (!\is_array($v) || 1 !== \count($v) || 10 !== \strlen($k = (string) key($v)) || "\x9D" !== $k[0] || "\0" !== $k[5] || "\x5F" !== $k[9]) {
+            return false;
+        }
+
+        return true;
+    }
+}
+
+?>

rules-tests/DowngradePhp73/Rector/FuncCall/DowngradeArrayKeyFirstLastRector/Fixture/possible_non_array_or_object_array_key_last.php.inc

@@ -0,0 +1,46 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp73\Rector\FuncCall\DowngradeArrayKeyFirstLastRector\Fixture;
+
+class PossibleNonArrayOrObjectArrayKeyLast
+{
+    protected mixed $value = null;
+
+    private function run(): bool
+    {
+        $v = $this->value;
+
+        if (!\is_array($v) || 1 !== \count($v) || 10 !== \strlen($k = (string) array_key_last($v)) || "\x9D" !== $k[0] || "\0" !== $k[5] || "\x5F" !== $k[9]) {
+            return false;
+        }
+
+        return true;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp73\Rector\FuncCall\DowngradeArrayKeyFirstLastRector\Fixture;
+
+class PossibleNonArrayOrObjectArrayKeyLast
+{
+    protected mixed $value = null;
+
+    private function run(): bool
+    {
+        $v = $this->value;
+        if (is_array($v)) {
+            end($v);
+        }
+
+        if (!\is_array($v) || 1 !== \count($v) || 10 !== \strlen($k = (string) key($v)) || "\x9D" !== $k[0] || "\0" !== $k[5] || "\x5F" !== $k[9]) {
+            return false;
+        }
+
+        return true;
+    }
+}
+
+?>

rules/DowngradePhp73/Rector/FuncCall/DowngradeArrayKeyFirstLastRector.php

@@ -8,6 +8,7 @@
 use PhpParser\Node\Arg;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Assign;
+use PhpParser\Node\Expr\BinaryOp\BooleanOr;
 use PhpParser\Node\Expr\CallLike;
 use PhpParser\Node\Expr\Cast\Array_;
 use PhpParser\Node\Expr\FuncCall;
@@ -17,8 +18,10 @@
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Name;
+use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\Echo_;
 use PhpParser\Node\Stmt\Expression;
+use PhpParser\Node\Stmt\If_;
 use PhpParser\Node\Stmt\Return_;
 use PhpParser\Node\Stmt\Switch_;
 use PHPStan\Analyser\Scope;
@@ -161,15 +164,14 @@ private function refactorArrayKeyFirst(
         }
 
         $resetFuncCall = $this->nodeFactory->createFuncCall('reset', [$array]);
-        $resetFuncCallExpression = new Expression($resetFuncCall);
+        $newStmts[] = $this->resolvePrependNewStmt($array, $resetFuncCall, $stmt);
 
         $funcCall->name = new Name('key');
         if ($originalArray !== $array) {
             $firstArg = $args[0];
             $firstArg->value = $array;
         }
 
-        $newStmts[] = $resetFuncCallExpression;
         $newStmts[] = $stmt;
 
         return $newStmts;
@@ -203,8 +205,7 @@ private function refactorArrayKeyLast(
         }
 
         $endFuncCall = $this->nodeFactory->createFuncCall('end', [$array]);
-        $endFuncCallExpression = new Expression($endFuncCall);
-        $newStmts[] = $endFuncCallExpression;
+        $newStmts[] = $this->resolvePrependNewStmt($array, $endFuncCall, $stmt);
 
         $funcCall->name = new Name('key');
         if ($originalArray !== $array) {
@@ -216,6 +217,18 @@ private function refactorArrayKeyLast(
         return $newStmts;
     }
 
+    private function resolvePrependNewStmt(Expr|Variable $array, FuncCall $funcCall, Stmt $stmt): Expression|If_
+    {
+        if (! $stmt instanceof If_ || $stmt->cond instanceof FuncCall || ! $stmt->cond instanceof BooleanOr) {
+            return new Expression($funcCall);
+        }
+
+        $if = new If_($this->nodeFactory->createFuncCall('is_array', [$array]));
+        $if->stmts[] = new Expression($funcCall);
+
+        return $if;
+    }
+
     private function resolveCastedArray(Expr $expr): Expr|Variable
     {
         if (! $expr instanceof Array_) {