Fix php 8.4 compatible code BitwiseFlagCleaner

samsonasik · web-flow · commit a667cc746ebb · 2025-01-27T23:08:20.000+07:00
ref https://github.com/rectorphp/rector/pull/8990/files#diff-6a4a6fe9ef9b7755c813ac48865f8dd16de0bff4ff4140b9f707b3ffa8e81e58
diff --git a/rules/DowngradePhp72/NodeManipulator/BitwiseFlagCleaner.php b/rules/DowngradePhp72/NodeManipulator/BitwiseFlagCleaner.php
@@ -18,7 +18,7 @@ public function __construct(
     ) {
     }
 
-    public function cleanFuncCall(FuncCall $funcCall, BitwiseOr $bitwiseOr, string $flag, Expr $expr = null): void
+    public function cleanFuncCall(FuncCall $funcCall, BitwiseOr $bitwiseOr, string $flag, ?Expr $expr = null): void
     {
         if ($bitwiseOr->left instanceof BitwiseOr) {
             /** @var BitwiseOr $leftLeft */

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ public function __construct(`
`18`	`18`	`) {`
`19`	`19`	`}`
`20`	`20`
`21`		`- public function cleanFuncCall(FuncCall $funcCall, BitwiseOr $bitwiseOr, string $flag, Expr $expr = null): void`
	`21`	`+ public function cleanFuncCall(FuncCall $funcCall, BitwiseOr $bitwiseOr, string $flag, ?Expr $expr = null): void`
`22`	`22`	`{`
`23`	`23`	`if ($bitwiseOr->left instanceof BitwiseOr) {`
`24`	`24`	`/** @var BitwiseOr $leftLeft */`