fix constant type on DowngradeNamedArgumentRector

samsonasik · samsonasik · commit abd18bf33e57 · 2024-11-20T00:09:35.000+07:00
diff --git a/rules/DowngradePhp80/Reflection/DefaultParameterValueResolver.php b/rules/DowngradePhp80/Reflection/DefaultParameterValueResolver.php
@@ -25,14 +25,14 @@ public function resolveFromParameterReflection(ParameterReflection $parameterRef
             return null;
         }
 
-        if (! $defaultValueType instanceof ConstantType) {
+        if (! $defaultValueType->isConstantValue()->yes()) {
             throw new ShouldNotHappenException();
         }
 
         return $this->resolveValueFromType($defaultValueType);
     }
 
-    private function resolveValueFromType(ConstantType $constantType): ConstFetch | Expr
+    private function resolveValueFromType(Type $constantType): ConstFetch | Expr
     {
         if ($constantType instanceof ConstantBooleanType) {
             return $this->resolveConstantBooleanType($constantType);

Original file line number	Diff line number	Diff line change
`@@ -25,14 +25,14 @@ public function resolveFromParameterReflection(ParameterReflection $parameterRef`
`25`	`25`	`return null;`
`26`	`26`	`}`
`27`	`27`
`28`		`- if (! $defaultValueType instanceof ConstantType) {`
	`28`	`+ if (! $defaultValueType->isConstantValue()->yes()) {`
`29`	`29`	`throw new ShouldNotHappenException();`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`return $this->resolveValueFromType($defaultValueType);`
`33`	`33`	`}`
`34`	`34`
`35`		`- private function resolveValueFromType(ConstantType $constantType): ConstFetch \| Expr`
	`35`	`+ private function resolveValueFromType(Type $constantType): ConstFetch \| Expr`
`36`	`36`	`{`
`37`	`37`	`if ($constantType instanceof ConstantBooleanType) {`
`38`	`38`	`return $this->resolveConstantBooleanType($constantType);`