cleanup ignored phpstan notice

samsonasik · samsonasik · commit e88b23505cd4 · 2025-11-28T20:18:13.000+07:00
diff --git a/phpstan.neon b/phpstan.neon
@@ -48,9 +48,6 @@ parameters:
 
         - '#(.*?)\:\:refactor\(\) should return array<PhpParser\\Node\\Stmt>\|PhpParser\\Node\\Stmt\\ClassConst\|null but returns array<PhpParser\\Node\\Stmt>\|PhpParser\\Node\\Stmt\|null#'
 
-        # phpstan need to load rector nodes first to avoid this
-        - '#Access to an undefined property Rector\\Contract\\PhpParser\\Node\\StmtsAwareInterface\:\:\$stmts#'
-
         -
             message: '#Parameter \#1 \$attributeClass of class Rector\\DowngradePhp80\\ValueObject\\DowngradeAttributeToAnnotation constructor expects class\-string, string given#'
             path: "config/*"
@@ -70,7 +67,6 @@ parameters:
             identifier: argument.type
 
         - '#Asking about instanceof PHPStan\\.* is not covered by backward compatibility promise#'
-        - '#Method Rector\\(.*?)\\Rector\\FuncCall\\(.*?)::refactor\(\) never returns \d so it can be removed from the return type#'
 
         # false positive intanceof in OR usage
         -

Original file line number	Diff line number	Diff line change
`@@ -48,9 +48,6 @@ parameters:`
`48`	`48`
`49`	`49`	`- '#(.*?)\:\:refactor\(\) should return array<PhpParser\\Node\\Stmt>\\|PhpParser\\Node\\Stmt\\ClassConst\\|null but returns array<PhpParser\\Node\\Stmt>\\|PhpParser\\Node\\Stmt\\|null#'`
`50`	`50`
`51`		`- # phpstan need to load rector nodes first to avoid this`
`52`		`- - '#Access to an undefined property Rector\\Contract\\PhpParser\\Node\\StmtsAwareInterface\:\:\$stmts#'`
`53`		`-`
`54`	`51`	`-`
`55`	`52`	`message: '#Parameter \#1 \$attributeClass of class Rector\\DowngradePhp80\\ValueObject\\DowngradeAttributeToAnnotation constructor expects class\-string, string given#'`
`56`	`53`	`path: "config/*"`
`@@ -70,7 +67,6 @@ parameters:`
`70`	`67`	`identifier: argument.type`
`71`	`68`
`72`	`69`	`- '#Asking about instanceof PHPStan\\.* is not covered by backward compatibility promise#'`
`73`		`- - '#Method Rector\\(.?)\\Rector\\FuncCall\\(.?)::refactor\(\) never returns \d so it can be removed from the return type#'`
`74`	`70`
`75`	`71`	`# false positive intanceof in OR usage`
`76`	`72`	`-`