[DowngradePhp80] Skip native AllowDynamicProperties attribute on DowngradeAttributeToAnnotationRector (#248)

* [DowngradePhp80] Skip native AllowDynamicProperties attribute on DowngradeAttributeToAnnotationRector

* fix

* add fixture to reprint on same line

* reprint with skipped attribute

* future comment

Author: samsonasik

rules-tests/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector/Fixture/reprint_same_line.php.inc

@@ -0,0 +1,24 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\Class_\DowngradeAttributeToAnnotationRector\Fixture;
+
+use AllowDynamicProperties;
+
+#[AllowDynamicProperties]class ReprintSameLine
+{
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\Class_\DowngradeAttributeToAnnotationRector\Fixture;
+
+use AllowDynamicProperties;
+
+#[AllowDynamicProperties]
+class ReprintSameLine
+{
+}
+
+?>

rules-tests/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector/Fixture/skip_allow_dynamic_properties.php.inc

@@ -0,0 +1,10 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\Class_\DowngradeAttributeToAnnotationRector\Fixture;
+
+use AllowDynamicProperties;
+
+#[AllowDynamicProperties]
+class User
+{
+}

rules/DowngradePhp80/Rector/Class_/DowngradeAttributeToAnnotationRector.php

@@ -19,6 +19,7 @@
 use Rector\Contract\Rector\ConfigurableRectorInterface;
 use Rector\DowngradePhp80\ValueObject\DowngradeAttributeToAnnotation;
 use Rector\NodeFactory\DoctrineAnnotationFactory;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -34,7 +35,7 @@ final class DowngradeAttributeToAnnotationRector extends AbstractRector implemen
     /**
      * @var string[]
      */
-    private const SKIPPED_ATTRIBUTES = ['Attribute', 'ReturnTypeWillChange'];
+    private const SKIPPED_ATTRIBUTES = ['Attribute', 'ReturnTypeWillChange', 'AllowDynamicProperties'];
 
     /**
      * @var DowngradeAttributeToAnnotation[]
@@ -105,9 +106,14 @@ public function refactor(Node $node): ?Node
         $this->isDowngraded = false;
 
         $phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($node);
+        $requireReprint = false;
         foreach ($node->attrGroups as $attrGroup) {
             foreach ($attrGroup->attrs as $key => $attribute) {
                 if ($this->shouldSkipAttribute($attribute)) {
+                    // avoid error on same line
+                    // as attribute ->getStartLine() always equal with node ->getStartLine()
+                    // can't validate it, so enforce to reprint later
+                    $requireReprint = true;
                     continue;
                 }
 
@@ -145,6 +151,11 @@ public function refactor(Node $node): ?Node
         $this->cleanupEmptyAttrGroups($node);
 
         if (! $this->isDowngraded) {
+            if ($requireReprint) {
+                $node->setAttribute(AttributeKey::ORIGINAL_NODE, null);
+                return $node;
+            }
+
             return null;
         }