[DowngradePhp80] Add DowngradeSubstrFalsyRector

Author: samsonasik

config/set/downgrade-php80.php

@@ -23,6 +23,7 @@
 use Rector\DowngradePhp80\Rector\FuncCall\DowngradeStrContainsRector;
 use Rector\DowngradePhp80\Rector\FuncCall\DowngradeStrEndsWithRector;
 use Rector\DowngradePhp80\Rector\FuncCall\DowngradeStrStartsWithRector;
+use Rector\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector;
 use Rector\DowngradePhp80\Rector\FunctionLike\DowngradeMixedTypeDeclarationRector;
 use Rector\DowngradePhp80\Rector\FunctionLike\DowngradeUnionTypeDeclarationRector;
 use Rector\DowngradePhp80\Rector\Instanceof_\DowngradeInstanceofStringableRector;
@@ -91,5 +92,6 @@
         RemoveReturnTypeDeclarationFromCloneRector::class,
         DowngradeEnumToConstantListClassRector::class,
         DowngradeInstanceofStringableRector::class,
+        DowngradeSubstrFalsyRector::class,
     ]);
 };

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/DowngradeSubstrFalsyRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class DowngradeSubstrFalsyRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/by_variable_string.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class ByVariableString
+{
+    public function run(string $name)
+    {
+        return substr($name, 2);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class ByVariableString
+{
+    public function run(string $name)
+    {
+        return (string) substr($name, 2);
+    }
+}
+
+?>

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/fixture.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class Fixture
+{
+    public function run()
+    {
+        return substr("a", 2);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class Fixture
+{
+    public function run()
+    {
+        return (string) substr("a", 2);
+    }
+}
+
+?>

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/skip_already_casted.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class SkipAlreadyCasted
+{
+    public function run()
+    {
+        return (string) substr("a", 2);
+    }
+}

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/skip_different_func_call.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class SkipDifferentFuncCall
+{
+    public function run()
+    {
+        return strlen('a');
+    }
+}

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/skip_empty.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+/**
+ * empty can be false or empty string ""
+ */
+class SkipEmpty
+{
+    public function run()
+    {
+        return empty(substr("a", 2));
+    }
+}

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/skip_never_empty.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class SkipNeverEmpty
+{
+    public function run()
+    {
+        return substr("abc", 2);
+    }
+}

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/Fixture/skip_ternary_falsy.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector\Fixture;
+
+class SkipTernaryFalsy
+{
+    public function run()
+    {
+        return substr('a', 2) ?: 'default';
+    }
+}

rules-tests/DowngradePhp80/Rector/FuncCall/DowngradeSubstrFalsyRector/config/configured_rule.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\DowngradePhp80\Rector\FuncCall\DowngradeSubstrFalsyRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(DowngradeSubstrFalsyRector::class);
+};