[fix] Improve AssertComparisonToSpecificMethodRector for assert false (#594)

* fix test namespace

* [fix] Improve AssertComparisonToSpecificMethodRector for assert false

Author: TomasVotruba

rules-tests/CodeQuality/Rector/MethodCall/AssertComparisonToSpecificMethodRector/Fixture/assert_false_greater.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class AssertFalseGreater extends TestCase
+{
+    public function some(int $param)
+    {
+        self::assertFalse($param > 0);
+
+        self::assertFalse($param >= 10);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class AssertFalseGreater extends TestCase
+{
+    public function some(int $param)
+    {
+        self::assertLessThanOrEqual(0, $param);
+
+        self::assertLessThan(10, $param);
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/MethodCall/AssertComparisonToSpecificMethodRector/Fixture/assert_false_smaller.php.inc

@@ -0,0 +1,35 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class AssertFalseSmaller extends TestCase
+{
+    public function some(int $param)
+    {
+        self::assertFalse(0 < $param);
+
+        self::assertFalse(10 <= $param);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class AssertFalseSmaller extends TestCase
+{
+    public function some(int $param)
+    {
+        self::assertGreaterThanOrEqual($param, 0);
+
+        self::assertGreaterThan($param, 10);
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/MethodCall/AssertComparisonToSpecificMethodRector/Fixture/assert_true_to_greater_than.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\PHPUnit\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
 
 use PHPUnit\Framework\TestCase;
 
@@ -17,7 +17,7 @@ final class AssertTrueToGreaterThan extends TestCase
 -----
 <?php
 
-namespace Rector\Tests\PHPUnit\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
 
 use PHPUnit\Framework\TestCase;
 

rules-tests/CodeQuality/Rector/MethodCall/AssertComparisonToSpecificMethodRector/Fixture/assert_true_to_less_than.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\PHPUnit\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
 
 use PHPUnit\Framework\TestCase;
 
@@ -17,7 +17,7 @@ final class AssertTrueToLessThan extends TestCase
 -----
 <?php
 
-namespace Rector\Tests\PHPUnit\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector\Fixture;
 
 use PHPUnit\Framework\TestCase;
 

rules-tests/CodeQuality/Rector/MethodCall/AssertEqualsToSameRector/Fixture/skip_if_an_object_is_in_any_level_of_an_array.php.inc

@@ -3,7 +3,7 @@
 namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertEqualsToSameRector\Fixture;
 
 use PHPUnit\Framework\TestCase;
-use Rector\Tests\PHPUnit\Rector\MethodCall\AssertEqualsToSameRector\Fixture\DateTimeImmutable;
+use Rector\PHPUnit\Tests\Rector\MethodCall\AssertEqualsToSameRector\Fixture\DateTimeImmutable;
 
 final class Test extends TestCase
 {

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_abstract_method.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\PHPUnit\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+namespace Rector\PHPUnit\Tests\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
 
 use PHPUnit\Framework\TestCase;
 

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_call_expect_not_to_perform_assertions_method_call.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\PHPUnit\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+namespace Rector\PHPUnit\Tests\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
 
 use Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Source\Factory;
 

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_mock_expectations.php.inc

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace Rector\Tests\PHPUnit\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+namespace Rector\PHPUnit\Tests\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
 
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;

rules-tests/PHPUnit60/Rector/MethodCall/GetMockBuilderGetMockToCreateMockRector/Fixture/skip_no_instanceof_testcase.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\PHPUnit\PHPUnit60\Rector\MethodCall\GetMockBuilderGetMockToCreateMockRector\Fixture;
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\MethodCall\GetMockBuilderGetMockToCreateMockRector\Fixture;
 
 class MockFactory
 {

rules/CodeQuality/Rector/MethodCall/AssertComparisonToSpecificMethodRector.php

@@ -46,18 +46,12 @@ public function __construct(
             new BinaryOpWithAssertMethod(NotIdentical::class, 'assertNotSame', 'assertSame'),
             new BinaryOpWithAssertMethod(Equal::class, 'assertEquals', 'assertNotEquals'),
             new BinaryOpWithAssertMethod(NotEqual::class, 'assertNotEquals', 'assertEquals'),
-            new BinaryOpWithAssertMethod(Greater::class, 'assertGreaterThan', 'assertLessThan'),
-            new BinaryOpWithAssertMethod(Smaller::class, 'assertLessThan', 'assertGreaterThan'),
-            new BinaryOpWithAssertMethod(
-                GreaterOrEqual::class,
-                'assertGreaterThanOrEqual',
-                'assertLessThanOrEqual'
-            ),
-            new BinaryOpWithAssertMethod(
-                SmallerOrEqual::class,
-                'assertLessThanOrEqual',
-                'assertGreaterThanOrEqual'
-            ),
+
+            new BinaryOpWithAssertMethod(Greater::class, 'assertGreaterThan', 'assertLessThanOrEqual'),
+            new BinaryOpWithAssertMethod(Smaller::class, 'assertLessThan', 'assertGreaterThanOrEqual'),
+            new BinaryOpWithAssertMethod(GreaterOrEqual::class, 'assertGreaterThanOrEqual', 'assertLessThan'),
+
+            new BinaryOpWithAssertMethod(SmallerOrEqual::class, 'assertLessThanOrEqual', 'assertGreaterThan'),
         ];
     }