[DeadCode] Skip final and non-public __construct() on RemoveParentDelegatingConstructorRector (#7806)

* [DeadCode] Skip final and non-public __construct() on RemoveParentDelegatingConstructorRector

* skip final

* skip non-public

* final touch: better demo fixxture

Author: samsonasik

rules-tests/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector/Fixture/skip_final_construct.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveParentDelegatingConstructorRector\Fixture;
+
+use PhpParser\Node\Scalar\String_;
+
+final class SkipFinalConstruct extends String_
+{
+    final public function __construct($value, $attributes)
+    {
+        parent::__construct($value, $attributes);
+    }
+}

rules-tests/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector/Fixture/skip_private_construct.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveParentDelegatingConstructorRector\Fixture;
+
+use PhpParser\Node\Scalar\String_;
+
+final class SkipPrivateConstruct extends String_
+{
+    private function __construct($value, $attributes)
+    {
+        parent::__construct($value, $attributes);
+    }
+
+    public static function create($value, $attributes)
+    {
+        return new self($value, $attributes);
+    }
+}

rules/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector.php

@@ -98,6 +98,14 @@ public function refactor(Node $node): ?int
             return null;
         }
 
+        if ($node->isFinal()) {
+            return null;
+        }
+
+        if (! $node->isPublic()) {
+            return null;
+        }
+
         $parentMethodReflection = $this->matchParentConstructorReflection($node);
         if (! $parentMethodReflection instanceof ExtendedMethodReflection) {
             return null;