Make getVisitorsForNode function public

Author: carlos-granados

patches/nikic-php-parser-lib-phpparser-nodetraverser-php.patch

@@ -47,7 +47,7 @@
 +    /**
 +     * @return NodeVisitor[]
 +     */
-+    protected function getVisitorsForNode(Node $node)
++    public function getVisitorsForNode(Node $node)
 +    {
 +        return $this->visitors;
      }

src/PhpParser/NodeTraverser/RectorNodeTraverser.php

@@ -60,7 +60,7 @@ public function refreshPhpRectors(array $rectors): void
      *
      * @return NodeVisitor[]
      */
-    protected function getVisitorsForNode(Node $node): array
+    public function getVisitorsForNode(Node $node): array
     {
         $nodeClass = $node::class;
         if (! isset($this->visitorsPerNodeClass[$nodeClass])) {

tests/PhpParser/NodeTraverser/RectorNodeTraverserTest.php

@@ -10,14 +10,11 @@
 use Rector\Tests\PhpParser\NodeTraverser\Class_\RuleUsingClassRector;
 use Rector\Tests\PhpParser\NodeTraverser\ClassLike\RuleUsingClassLikeRector;
 use Rector\Tests\PhpParser\NodeTraverser\Function_\RuleUsingFunctionRector;
-use Rector\Util\Reflection\PrivatesAccessor;
 
 final class RectorNodeTraverserTest extends AbstractLazyTestCase
 {
     private RectorNodeTraverser $rectorNodeTraverser;
 
-    private PrivatesAccessor $privatesAccessor;
-
     private RuleUsingFunctionRector $ruleUsingFunctionRector;
 
     private RuleUsingClassRector $ruleUsingClassRector;
@@ -29,8 +26,6 @@ protected function setUp(): void
         $this->rectorNodeTraverser = $this->make(RectorNodeTraverser::class);
         $this->rectorNodeTraverser->refreshPhpRectors([]);
 
-        $this->privatesAccessor = new PrivatesAccessor();
-
         $this->ruleUsingFunctionRector = new RuleUsingFunctionRector();
         $this->ruleUsingClassRector = new RuleUsingClassRector();
         $this->ruleUsingClassLikeRector = new RuleUsingClassLikeRector();
@@ -39,11 +34,8 @@ protected function setUp(): void
     public function testGetVisitorsForNodeWhenNoVisitorsAvailable(): void
     {
         $class = new Class_('test');
-        $visitors = $this->privatesAccessor->callPrivateMethod(
-            $this->rectorNodeTraverser,
-            'getVisitorsForNode',
-            [$class]
-        );
+
+        $visitors = $this->rectorNodeTraverser->getVisitorsForNode($class);
 
         $this->assertSame([], $visitors);
     }
@@ -52,11 +44,8 @@ public function testGetVisitorsForNodeWhenNoVisitorsMatch(): void
     {
         $class = new Class_('test');
         $this->rectorNodeTraverser->addVisitor($this->ruleUsingFunctionRector);
-        $visitors = $this->privatesAccessor->callPrivateMethod(
-            $this->rectorNodeTraverser,
-            'getVisitorsForNode',
-            [$class]
-        );
+
+        $visitors = $this->rectorNodeTraverser->getVisitorsForNode($class);
 
         $this->assertSame([], $visitors);
     }
@@ -67,11 +56,7 @@ public function testGetVisitorsForNodeWhenSomeVisitorsMatch(): void
         $this->rectorNodeTraverser->addVisitor($this->ruleUsingFunctionRector);
         $this->rectorNodeTraverser->addVisitor($this->ruleUsingClassRector);
 
-        $visitors = $this->privatesAccessor->callPrivateMethod(
-            $this->rectorNodeTraverser,
-            'getVisitorsForNode',
-            [$class]
-        );
+        $visitors = $this->rectorNodeTraverser->getVisitorsForNode($class);
 
         $this->assertEquals([$this->ruleUsingClassRector], $visitors);
     }
@@ -82,11 +67,7 @@ public function testGetVisitorsForNodeWhenAllVisitorsMatch(): void
         $this->rectorNodeTraverser->addVisitor($this->ruleUsingClassRector);
         $this->rectorNodeTraverser->addVisitor($this->ruleUsingClassLikeRector);
 
-        $visitors = $this->privatesAccessor->callPrivateMethod(
-            $this->rectorNodeTraverser,
-            'getVisitorsForNode',
-            [$class]
-        );
+        $visitors = $this->rectorNodeTraverser->getVisitorsForNode($class);
 
         $this->assertEquals([$this->ruleUsingClassRector, $this->ruleUsingClassLikeRector], $visitors);
     }
@@ -97,20 +78,12 @@ public function testGetVisitorsForNodeUsesCachedValue(): void
         $this->rectorNodeTraverser->addVisitor($this->ruleUsingClassRector);
         $this->rectorNodeTraverser->addVisitor($this->ruleUsingClassLikeRector);
 
-        $visitors = $this->privatesAccessor->callPrivateMethod(
-            $this->rectorNodeTraverser,
-            'getVisitorsForNode',
-            [$class]
-        );
+        $visitors = $this->rectorNodeTraverser->getVisitorsForNode($class);
 
         $this->assertEquals([$this->ruleUsingClassRector, $this->ruleUsingClassLikeRector], $visitors);
 
         $this->rectorNodeTraverser->removeVisitor($this->ruleUsingClassRector);
-        $visitors = $this->privatesAccessor->callPrivateMethod(
-            $this->rectorNodeTraverser,
-            'getVisitorsForNode',
-            [$class]
-        );
+        $visitors = $this->rectorNodeTraverser->getVisitorsForNode($class);
 
         $this->assertEquals([$this->ruleUsingClassRector, $this->ruleUsingClassLikeRector], $visitors);
     }